From: "Ludovic Courtès" <ludo@gnu.org>
To: Steve George <steve@futurile.net>
Cc: nicolas.debonnaire@gmail.com, 67257@debbugs.gnu.org
Subject: [bug#67257] [PATCH v2 2/2] gnu: Add x2goclient.
Date: Tue, 27 Feb 2024 11:02:41 +0100 [thread overview]
Message-ID: <87msrmi5ry.fsf@gnu.org> (raw)
In-Reply-To: <89c8896f76e5c5e3f68dfd7f36cac23ad3a79330.1708638616.git.steve@futurile.net> (Steve George's message of "Thu, 22 Feb 2024 22:08:20 +0000")
Steve George <steve@futurile.net> skribis:
> From: nicodebo <nicolas.debonnaire@gmail.com>
>
> * gnu/packages/nx.scm (x2goclient): New variable.
>
> Reviewed-by: Steve George <steve@futurile.net>
>
> Change-Id: Ib0ff6328ede3fb4a0b48462ac1a003438c53c862
[...]
> + (substitute* "src/onmainwindow.cpp"
> + (("/usr/sbin/sshd")
> + (which "sshd"))))))
Rather use ‘search-input-file’ here, as mentioned in my other message.
> + (native-inputs (list pkg-config
> + qttools-5
> + qtbase-5
> + qtx11extras
> + qtsvg-5
> + libssh
> + cups
> + libxpm
> + openldap
> + gcc-toolchain))
You can omit ‘gcc-toolchain’. Most likely, everything but ‘pkg-config’
and ‘qttools-5’ shold be in ‘inputs’ rather than ‘native-inputs’.
> + (propagated-inputs (list nx-libs
> + openssh))
Don’t propagate OpenSSH: it should be up to the user to install it if
they want it, to avoid being too intrusive.
‘nx-libs’ probably doesn’t need to be propagated either and can be in
‘inputs’, no?
Could you send updated patches?
Thanks!
Ludo’.
next prev parent reply other threads:[~2024-02-27 10:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 18:46 [bug#67257] [PATCH 0/2] add x2goclient nicodebo
2023-11-18 7:59 ` [bug#67257] [PATCH 1/2] Add nx-libs nicodebo
2023-11-18 7:59 ` [bug#67257] [PATCH 2/2] Add x2goclient nicodebo
2024-02-22 22:08 ` [bug#67257] [PATCH v2 0/2] re: add x2goclient and nx-libs Steve George
2024-02-22 22:08 ` [bug#67257] [PATCH v2 1/2] gnu: Add nx-libs Steve George
2024-02-27 9:59 ` Ludovic Courtès
2024-03-10 0:40 ` Maxim Cournoyer
2024-02-22 22:08 ` [bug#67257] [PATCH v2 2/2] gnu: Add x2goclient Steve George
2024-02-27 10:02 ` Ludovic Courtès [this message]
2024-03-10 0:45 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msrmi5ry.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=67257@debbugs.gnu.org \
--cc=nicolas.debonnaire@gmail.com \
--cc=steve@futurile.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).