From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 2HuVAtKy3WWuBwEAe85BDQ:P1 (envelope-from ) for ; Tue, 27 Feb 2024 11:00:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 2HuVAtKy3WWuBwEAe85BDQ (envelope-from ) for ; Tue, 27 Feb 2024 11:00:50 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MoQJ7Uxv; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709028049; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rSUcaOG2UFMIPyj4Twq9gKcpgtOG+5R9nVjxo4OdloE=; b=TEsqHMibtqRfDebjewiFkLlkDHmC+jt5xqg+MFnl8bq4lAL4+LDjmeQdEF0LQLd9gSLotj N2tznYxKZwRJX/4eZ83icTUV7u86ggpSULmo55H4pHqSMPJKZnVrgucQ9rd6UmmzF9StY8 PIHptKeb6HVhTFfcOCKAUCtJ6dhtT27vd9tySLQ9bdYIBF1bkboE+od7I0vZ8AHQ2dGmHn oE5uGXd/LmKU0NxrftyocnwzUP27nSAaNVv9wSiI8+NYqiXc/0mcUEfbFTTvGVfPYsYmsK uYo8PavCDgBHsPbEBg+JY82COL6CxHJFzT5YS+xhGQ9jcPO6PsC2e1ArzqwU+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MoQJ7Uxv; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709028049; a=rsa-sha256; cv=none; b=HvVE4Ed7FCqZbkYTzCuJ3Xzb+pROA0nFV6nSBonqyZMENj6NIQL0DAp66TqSeIoHeCWAx+ 36EHKi9sMMNFEWCTamr06ObqKkU71sGHms+/yq6v/Javh5Th4T4I80bqqQmaBSHLJkOZe3 GLZ0m7yB88bwAJewm1smiEoCS2le+eFZvVGFlGrCVIA0B8tCyH2NslLuGsS8nBvWUR0pTz cM6RaDxCLZ87oriBF5apYy0rkuGs7LbGT1EFVT2VoKm4HBoagJ4Uw7dODQR6aBiv12odPn kjviAxOi/OmPAHDTL56fgeqUsB+hLBNFKmEws11R7xie9ynwqmAARoXxWWMarw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E812F38FDA for ; Tue, 27 Feb 2024 11:00:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1reuGN-0003bh-2Y; Tue, 27 Feb 2024 05:00:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reuGK-0003Wl-T3 for guix-patches@gnu.org; Tue, 27 Feb 2024 05:00:37 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1reuGK-0006WV-Il for guix-patches@gnu.org; Tue, 27 Feb 2024 05:00:36 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1reuGk-0007H6-7k; Tue, 27 Feb 2024 05:01:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67257] [PATCH v2 1/2] gnu: Add nx-libs. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org, steve@futurile.net Resent-Date: Tue, 27 Feb 2024 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67257 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Steve George Cc: nicolas.debonnaire@gmail.com, 67257@debbugs.gnu.org Received: via spool by 67257-submit@debbugs.gnu.org id=B67257.170902801427837 (code B ref 67257); Tue, 27 Feb 2024 10:01:02 +0000 Received: (at 67257) by debbugs.gnu.org; 27 Feb 2024 10:00:14 +0000 Received: from localhost ([127.0.0.1]:39496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reuFy-0007Eu-7r for submit@debbugs.gnu.org; Tue, 27 Feb 2024 05:00:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reuFv-0007DM-6L for 67257@debbugs.gnu.org; Tue, 27 Feb 2024 05:00:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reuFP-00063D-2G; Tue, 27 Feb 2024 04:59:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=rSUcaOG2UFMIPyj4Twq9gKcpgtOG+5R9nVjxo4OdloE=; b=MoQJ7UxvYCgu7y0+pLvm NOF4wisJ1cGVEFiPoeKN5L8KysFe9lRp8/9rNjXY/7r9yIFF+Y1Ft8UNO6LB+V9HWp+Cv1HbDEOvj I6g+9sKTo7pSWMPdJRUt9AyxC2DjsWcfFW+eX+umhF13QieSmTFphpvp+h5FYCuN47TbHwSf8bkg/ kliaqS4zEI5yN5zyfWQIYyruENMqjhYUlX8GHwbWqCgitL2hP1DXU78sfdXn9xlKDBTnM5Uc4xL5J QSYHwD/VXCXtrjwAMQ/Jh85C+qOQOfK+LSABv7Uk+Fb3Mf0B1lUeIho8ALsNxWZ8OB/RQDsygh+MU Bt7jA5FDt3B5XA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <834a3cc5e7e16f94691c1bb726f1dd1cc5edb6d0.1708638616.git.steve@futurile.net> (Steve George's message of "Thu, 22 Feb 2024 22:08:19 +0000") References: <834a3cc5e7e16f94691c1bb726f1dd1cc5edb6d0.1708638616.git.steve@futurile.net> Date: Tue, 27 Feb 2024 10:59:14 +0100 Message-ID: <87sf1ei5xp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.17 X-Spam-Score: -7.17 X-Migadu-Queue-Id: E812F38FDA X-Migadu-Scanner: mx13.migadu.com X-TUID: uJCjiHXKfDoI Hi! Thank you Steve for shepherding this patch set! Here are some comments on minor issues. Steve George skribis: > From: nicodebo > > * gnu/packages/nx.scm: New file. > * gnu/packages/nx.scm (nx-libs): New variable. The second line is unnecessary. Please make sure to add the file to =E2=80=98gnu/local.mk=E2=80=99. > +++ b/gnu/packages/nx.scm > @@ -0,0 +1,141 @@ > +;;; This file is part of GNU Guix. Looks like a couple of lines are missing from the usual header. > + (add-before 'build 'replace-shebang-nxdialog > + (lambda _ > + (substitute* "nxdialog/bin/nxdialog" > + (("#!/usr/bin/env python") > + (string-append "#!" > + (which "python3")))))) =E2=80=98which=E2=80=99 returns =E2=80=98python3=E2=80=99 as found in $PATH= =E2=80=94i.e., the native python. To do the right thing in a cross-compilation context (for example, pick the AArch64 =E2=80=98python3=E2=80=99 binary if you=E2=80=99re cross-compil= ing to AArch64), it should be written like this: (lambda* (#:key inputs #:allow-other-keys) (substitute* =E2=80=A6 (=E2=80=A6 =E2=80=A6 (search-input-file inputs "/bin/python3")))) > + (synopsis "NX remote desktop library") > + (description > + "NX technology also known as NX or NoMachine is a protocol that ena= bles > +remote desktop access. It's maintained by the artica project, x2go > +developers and TheQVD.") Please describe that the package does; who maintains it is usually not relevant here: https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.= html Thanks, Ludo=E2=80=99.