From: Alex Kost <alezost@gmail.com>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: 28327@debbugs.gnu.org
Subject: [bug#28327] [PATCH] gnu: Add emacs-bash-completion.
Date: Mon, 04 Sep 2017 21:48:42 +0300 [thread overview]
Message-ID: <87r2vmwb91.fsf@gmail.com> (raw)
In-Reply-To: <20170902091112.1336-1-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Sat, 2 Sep 2017 11:11:12 +0200")
Jan Nieuwenhuizen (2017-09-02 11:11 +0200) wrote:
> ---
> gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 612126eb3..f6165ba54 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -59,6 +59,7 @@
> #:use-module (guix build-system trivial)
> #:use-module (gnu packages)
> #:use-module (gnu packages audio)
> + #:use-module (gnu packages bash)
> #:use-module (gnu packages code)
> #:use-module (gnu packages guile)
> #:use-module (gnu packages gtk)
> @@ -5444,3 +5445,27 @@ key. Optionally, a mouse pop-up can be added by binding
> version of Idris, and some features may rely on the latest Git version of
> Idris.")
> (license license:gpl3+)))
> +
> +(define-public emacs-batch-completion
> + (package
> + (name "emacs-bash-completion")
> + (version "20170901.1445")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://melpa.org/packages/bash-completion-"
Please use the source directly from the upstream, i.e.:
https://github.com/szermatt/emacs-bash-completion/archive/v2.0.0.tar.gz
There is a problem with MELPA: when there will be a new commit in the
repo, the new melpa tarball will be generated and the previous one
("20170901.1445") will be *removed*, so this package will lose its
source.
> + version
> + ".tar"))
I wouldn't leave ‘version’ and ‘".tar"’ on separate lines, but it's a
matter of taste :-)
> + (sha256
> + (base32
> + "12ggygcfhny5sqq18zn6qyyqbh9314niywjagv9nclwxfa0i9pvr"))))
> + (native-inputs `(("bash" ,bash)))
You probably meant to make this package call this "bash" (btw it should
be 'input', not 'native-input') from store, but this is not enough. You
also need to patch 'bash-completion-prog' variable using
'emacs-substitute-variables' procedure (see (gnu packages emacs) module
for the examples).
> + (build-system emacs-build-system)
> + (home-page "https://github.com/szermatt/emacs-bash-completion")
> + (synopsis "BASH completion for the shell buffer")
> + (description
> + "@code{bash-completion} defines dynamic completion hooks for shell-mode
> +and shell-command prompts that are based on bash completion.
> +")
Please put this quote and parenthesis to the previous line.
> + (license license:gpl3+)))
I see GPL 2 or later in "bash-completion.el".
--
Alex
next prev parent reply other threads:[~2017-09-04 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 9:11 [bug#28327] [PATCH] gnu: Add emacs-bash-completion Jan Nieuwenhuizen
2017-09-02 9:15 ` Jan Nieuwenhuizen
2017-09-04 18:48 ` Alex Kost [this message]
2017-09-06 17:52 ` Jan Nieuwenhuizen
2017-09-09 19:44 ` Alex Kost
2017-09-10 20:45 ` bug#28327: " Jan Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2vmwb91.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=28327@debbugs.gnu.org \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).