From: Alex Kost <alezost@gmail.com>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: 28327@debbugs.gnu.org
Subject: [bug#28327] [PATCH] gnu: Add emacs-bash-completion.
Date: Sat, 09 Sep 2017 22:44:17 +0300 [thread overview]
Message-ID: <87fubvslm6.fsf@gmail.com> (raw)
In-Reply-To: <877exb90jw.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Wed, 06 Sep 2017 19:52:51 +0200")
Jan Nieuwenhuizen (2017-09-06 19:52 +0200) wrote:
> Alex Kost writes:
[...]
>> You also need to patch 'bash-completion-prog' variable using
>> 'emacs-substitute-variables' procedure (see (gnu packages emacs)
>> module for the examples).
>
> I have added something here and built package works and looks okay...
Now it looks OK for me as well :-)
> Because adding bash to (native-)inputs already made that
> 'emacs-substitute-variables' is set to bash instead of bash-minimal, I
> don't really know how to test it.
I see that with your patch, 'bash-completion-prog' has the value
"/gnu/store/...-bash-4.4.12/bin/bash", so it is definitely 'bash'
('bash-minimal' has "/gnu/store/...-bash-minimal-4.4.12/bin/bash" name).
[...]
>>> + (license license:gpl3+)))
>>
>> I see GPL 2 or later in "bash-completion.el".
>
> I used guix import elpa --archive=melpa and didn't check. It seems we
> cannot rely on that!
We definitely shouldn't rely on it, as the importer always puts 'gpl3+':
http://git.savannah.gnu.org/cgit/guix.git/tree/guix/import/elpa.scm#n234
> New version attached, still 13 of the 30 lines were unchanged,
> wow...thanks for all your helpful remarks!
The patch looks good for me, thank you!
--
Alex
next prev parent reply other threads:[~2017-09-09 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 9:11 [bug#28327] [PATCH] gnu: Add emacs-bash-completion Jan Nieuwenhuizen
2017-09-02 9:15 ` Jan Nieuwenhuizen
2017-09-04 18:48 ` Alex Kost
2017-09-06 17:52 ` Jan Nieuwenhuizen
2017-09-09 19:44 ` Alex Kost [this message]
2017-09-10 20:45 ` bug#28327: " Jan Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fubvslm6.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=28327@debbugs.gnu.org \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).