From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dowQl-0003ml-Ri for guix-patches@gnu.org; Mon, 04 Sep 2017 14:49:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dowQh-00052m-2l for guix-patches@gnu.org; Mon, 04 Sep 2017 14:49:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40574) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dowQg-00052c-Uw for guix-patches@gnu.org; Mon, 04 Sep 2017 14:49:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dowQg-0001wD-H6 for guix-patches@gnu.org; Mon, 04 Sep 2017 14:49:02 -0400 Subject: [bug#28327] [PATCH] gnu: Add emacs-bash-completion. Resent-Message-ID: From: Alex Kost References: <20170902091112.1336-1-janneke@gnu.org> Date: Mon, 04 Sep 2017 21:48:42 +0300 In-Reply-To: <20170902091112.1336-1-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Sat, 2 Sep 2017 11:11:12 +0200") Message-ID: <87r2vmwb91.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jan Nieuwenhuizen Cc: 28327@debbugs.gnu.org Jan Nieuwenhuizen (2017-09-02 11:11 +0200) wrote: > --- > gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 612126eb3..f6165ba54 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -59,6 +59,7 @@ > #:use-module (guix build-system trivial) > #:use-module (gnu packages) > #:use-module (gnu packages audio) > + #:use-module (gnu packages bash) > #:use-module (gnu packages code) > #:use-module (gnu packages guile) > #:use-module (gnu packages gtk) > @@ -5444,3 +5445,27 @@ key. Optionally, a mouse pop-up can be added by b= inding > version of Idris, and some features may rely on the latest Git version of > Idris.") > (license license:gpl3+))) > + > +(define-public emacs-batch-completion > + (package > + (name "emacs-bash-completion") > + (version "20170901.1445") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "http://melpa.org/packages/bash-completion-" Please use the source directly from the upstream, i.e.: https://github.com/szermatt/emacs-bash-completion/archive/v2.0.0.tar.gz There is a problem with MELPA: when there will be a new commit in the repo, the new melpa tarball will be generated and the previous one ("20170901.1445") will be *removed*, so this package will lose its source. > + version > + ".tar")) I wouldn't leave =E2=80=98version=E2=80=99 and =E2=80=98".tar"=E2=80=99 on = separate lines, but it's a matter of taste :-) > + (sha256 > + (base32 > + "12ggygcfhny5sqq18zn6qyyqbh9314niywjagv9nclwxfa0i9pvr")))) > + (native-inputs `(("bash" ,bash))) You probably meant to make this package call this "bash" (btw it should be 'input', not 'native-input') from store, but this is not enough. You also need to patch 'bash-completion-prog' variable using 'emacs-substitute-variables' procedure (see (gnu packages emacs) module for the examples). > + (build-system emacs-build-system) > + (home-page "https://github.com/szermatt/emacs-bash-completion") > + (synopsis "BASH completion for the shell buffer") > + (description > + "@code{bash-completion} defines dynamic completion hooks for shell-= mode > +and shell-command prompts that are based on bash completion. > +") Please put this quote and parenthesis to the previous line. > + (license license:gpl3+))) I see GPL 2 or later in "bash-completion.el". --=20 Alex