From: Pierre Langlois <pierre.langlois@gmx.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 36194-done@debbugs.gnu.org
Subject: [bug#36194] [PATCH 05/10] gnu: Add python-leather.
Date: Sun, 07 Jul 2019 15:35:00 +0100 [thread overview]
Message-ID: <87r271x697.fsf@gmx.com> (raw)
In-Reply-To: <87zhlqards.fsf@gnu.org>
Ludovic Courtès writes:
> Hi Pierre!
>
> I applied the whole series after tweaking two descriptions.
>
> Two minor comments:
>
> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>
>> +;; Base package definition for packages from https://github.com/wireservice.
>> +;; This is done so we can share how to run tests and build documentation.
>> +(define base-package
>> + (package
>> + (name #f)
>> + (version #f)
>> + (source #f)
>> + (home-page #f)
>> + (synopsis #f)
>> + (description #f)
>> + (build-system python-build-system)
>
> As a matter of style, I would prefer to never have fields with a value
> of an invalid type, as is the case above; if one forgets to override
> these fields, we end up with an incorrect package.
>
> What about using ‘python-leather’ as the base package and defining a
> macro like:
>
> (define-syntax-rule (wireservice-package fields ...)
> (package
> (build-system python-build-system)
> (arguments (package-arguments python-leather))
> (native-inputs (package-native-inputs python-leather))
> fields ...))
>
> ?
Ah yeah I agree it's a much a better idea, I'll look into it as a
follow-up!
>
>> diff --git a/gnu/packages/patches/csvkit-fix-tests.patch b/gnu/packages/patches/csvkit-fix-tests.patch
>> new file mode 100644
>> index 0000000000..e62b601fe4
>> --- /dev/null
>> +++ b/gnu/packages/patches/csvkit-fix-tests.patch
>> @@ -0,0 +1,45 @@
>> +diff --git a/tests/test_utilities/test_csvsql.py b/tests/test_utilities/test_csvsql.py
>> +index e6ec4af..4f47980 100644
>> +--- a/tests/test_utilities/test_csvsql.py
>> ++++ b/tests/test_utilities/test_csvsql.py
>> +@@ -197,7 +197,7 @@ class TestCSVSQL(CSVKitTestCase, EmptyFileTests):
>> + utility.run()
>
> For your future self and for your fellow hackers ;-), it’d be great if
> you could add just a couple of lines at the top of each patch stating
> (1) where they come from, and (2) what they do.
Noted!
>
> Thanks for the patch series, and apologies for the delay!
Thanks for applying this and making adjustments!
Pierre
next prev parent reply other threads:[~2019-07-07 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 15:01 [bug#36194] [PATCH 00/10] Add csvkit Pierre Langlois
2019-06-13 15:06 ` [bug#36194] [PATCH 01/10] gnu: Add python-slugify Pierre Langlois
2019-06-13 15:06 ` [bug#36194] [PATCH 02/10] gnu: Add python-pytimeparse Pierre Langlois
2019-06-13 15:06 ` [bug#36194] [PATCH 03/10] gnu: Add python-crate Pierre Langlois
2019-06-13 15:06 ` [bug#36194] [PATCH 04/10] gnu: Add python-dbfread Pierre Langlois
2019-06-13 15:06 ` [bug#36194] [PATCH 05/10] gnu: Add python-leather Pierre Langlois
2019-07-07 13:47 ` bug#36194: " Ludovic Courtès
2019-07-07 14:35 ` Pierre Langlois [this message]
2019-06-13 15:06 ` [bug#36194] [PATCH 06/10] gnu: Add python-agate Pierre Langlois
2019-06-13 15:06 ` [bug#36194] [PATCH 07/10] gnu: Add python-agate-sql Pierre Langlois
2019-06-13 15:06 ` [bug#36194] [PATCH 08/10] gnu: Add python-agate-dbf Pierre Langlois
2019-06-13 15:06 ` [bug#36194] [PATCH 09/10] gnu: Add python-agate-excel Pierre Langlois
2019-06-21 10:42 ` [bug#36194] [PATCH 01/10 v2] gnu: Add python-slugify Pierre Langlois
2019-06-13 15:07 ` [bug#36194] [PATCH 10/10] gnu: Add csvkit Pierre Langlois
2019-07-06 20:01 ` [bug#36194] [PATCH 00/10] " Pierre Langlois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r271x697.fsf@gmx.com \
--to=pierre.langlois@gmx.com \
--cc=36194-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).