From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:50175) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hk8Gp-00043P-B9 for guix-patches@gnu.org; Sun, 07 Jul 2019 10:36:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hk8Go-0005te-4O for guix-patches@gnu.org; Sun, 07 Jul 2019 10:36:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48460) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hk8Go-0005tY-0X for guix-patches@gnu.org; Sun, 07 Jul 2019 10:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hk8Gn-0008VR-S9 for guix-patches@gnu.org; Sun, 07 Jul 2019 10:36:01 -0400 Subject: [bug#36194] [PATCH 05/10] gnu: Add python-leather. Resent-Message-ID: References: <20190613150126.17280-1-pierre.langlois@gmx.com> <20190613150627.1882-1-pierre.langlois@gmx.com> <20190613150627.1882-5-pierre.langlois@gmx.com> <87zhlqards.fsf@gnu.org> From: Pierre Langlois In-reply-to: <87zhlqards.fsf@gnu.org> Date: Sun, 07 Jul 2019 15:35:00 +0100 Message-ID: <87r271x697.fsf@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 36194-done@debbugs.gnu.org Ludovic Court=C3=A8s writes: > Hi Pierre! > > I applied the whole series after tweaking two descriptions. > > Two minor comments: > > Pierre Langlois skribis: > >> +;; Base package definition for packages from https://github.com/wireser= vice. >> +;; This is done so we can share how to run tests and build documentatio= n. >> +(define base-package >> + (package >> + (name #f) >> + (version #f) >> + (source #f) >> + (home-page #f) >> + (synopsis #f) >> + (description #f) >> + (build-system python-build-system) > > As a matter of style, I would prefer to never have fields with a value > of an invalid type, as is the case above; if one forgets to override > these fields, we end up with an incorrect package. > > What about using =E2=80=98python-leather=E2=80=99 as the base package and= defining a > macro like: > > (define-syntax-rule (wireservice-package fields ...) > (package > (build-system python-build-system) > (arguments (package-arguments python-leather)) > (native-inputs (package-native-inputs python-leather)) > fields ...)) > > ? Ah yeah I agree it's a much a better idea, I'll look into it as a follow-up! > >> diff --git a/gnu/packages/patches/csvkit-fix-tests.patch b/gnu/packages/= patches/csvkit-fix-tests.patch >> new file mode 100644 >> index 0000000000..e62b601fe4 >> --- /dev/null >> +++ b/gnu/packages/patches/csvkit-fix-tests.patch >> @@ -0,0 +1,45 @@ >> +diff --git a/tests/test_utilities/test_csvsql.py b/tests/test_utilities= /test_csvsql.py >> +index e6ec4af..4f47980 100644 >> +--- a/tests/test_utilities/test_csvsql.py >> ++++ b/tests/test_utilities/test_csvsql.py >> +@@ -197,7 +197,7 @@ class TestCSVSQL(CSVKitTestCase, EmptyFileTests): >> + utility.run() > > For your future self and for your fellow hackers ;-), it=E2=80=99d be gre= at if > you could add just a couple of lines at the top of each patch stating > (1) where they come from, and (2) what they do. Noted! > > Thanks for the patch series, and apologies for the delay! Thanks for applying this and making adjustments! Pierre