bug#36194: [PATCH 05/10] gnu: Add python-leather.

["Ludovic Courtès" <ludo@gnu.org>]

Hi Pierre!

I applied the whole series after tweaking two descriptions.

Two minor comments:

Pierre Langlois <pierre.langlois@gmx.com> skribis:

> +;; Base package definition for packages from https://github.com/wireservice.
> +;; This is done so we can share how to run tests and build documentation.
> +(define base-package
> +  (package
> +    (name #f)
> +    (version #f)
> +    (source #f)
> +    (home-page #f)
> +    (synopsis #f)
> +    (description #f)
> +    (build-system python-build-system)

As a matter of style, I would prefer to never have fields with a value
of an invalid type, as is the case above; if one forgets to override
these fields, we end up with an incorrect package.

What about using ‘python-leather’ as the base package and defining a
macro like:

  (define-syntax-rule (wireservice-package fields ...)
    (package
      (build-system python-build-system)
      (arguments (package-arguments python-leather))
      (native-inputs (package-native-inputs python-leather))
      fields ...))
        
?

> diff --git a/gnu/packages/patches/csvkit-fix-tests.patch b/gnu/packages/patches/csvkit-fix-tests.patch
> new file mode 100644
> index 0000000000..e62b601fe4
> --- /dev/null
> +++ b/gnu/packages/patches/csvkit-fix-tests.patch
> @@ -0,0 +1,45 @@
> +diff --git a/tests/test_utilities/test_csvsql.py b/tests/test_utilities/test_csvsql.py
> +index e6ec4af..4f47980 100644
> +--- a/tests/test_utilities/test_csvsql.py
> ++++ b/tests/test_utilities/test_csvsql.py
> +@@ -197,7 +197,7 @@ class TestCSVSQL(CSVKitTestCase, EmptyFileTests):
> +         utility.run()

For your future self and for your fellow hackers ;-), it’d be great if
you could add just a couple of lines at the top of each patch stating
(1) where they come from, and (2) what they do.

Thanks for the patch series, and apologies for the delay!

Ludo’.