unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@centurylink.net>
Cc: 31252@debbugs.gnu.org
Subject: [bug#31252] [PATCH] gnu: Add Ranger.
Date: Wed, 25 Apr 2018 23:09:39 +0200	[thread overview]
Message-ID: <87po2nngbw.fsf@gnu.org> (raw)
In-Reply-To: <1758300649.33991901.1524614953172.JavaMail.zimbra@centurylink.net> (Eric Bavier's message of "Tue, 24 Apr 2018 20:09:13 -0400 (EDT)")

Eric Bavier <ericbavier@centurylink.net> skribis:

> From 03abb95c7e551ea45d0742bf72cb78e5f0ce210e Mon Sep 17 00:00:00 2001
> From: Eric Bavier <ericbavier@centurylink.net>
> Date: Tue, 24 Apr 2018 18:44:38 -0500
> Subject: [PATCH] gnu: Add Ranger.
> To: guix-patches@gnu.org
>
> From: Eric Bavier <bavier@member.fsf.org>
>
> * gnu/packages/disk.scm (ranger): New variable.

[...]

> +(define-public ranger
> +  (package
> +    (name "ranger")
> +    (version "1.9.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://ranger.github.io/"
> +                                  "ranger-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "1lnzkrxcnlwnyi3z0v8ybyp8d5rm26qm35rr68kbs2lbs06inha0"))))

Patch was mangled.  :-)

> +    (build-system python-build-system)
> +    (native-inputs                      ;for tests
> +     `(("python-pytest" ,python-pytest)
> +       ("python-pylint" ,python-pylint)
> +       ("python-flake8" ,python-flake8)
> +       ("which" ,which)))
> +    (arguments
> +     '(#:phases (modify-phases %standard-phases
> +                  (replace 'check
> +                    (lambda _ (invoke "make" "test"))))))

You can use #:test-target "test" instead.

> +    (home-page "https://ranger.github.io/")
> +    (synopsis "Console file manager")
> +    (description "@code{ranger} is a console file manager with VI key

Nitpick: “Ranger” (or “ranger”?) and “Vi”.

I haven’t tried using it, but otherwise LGTM.  Thanks!

Ludo’.

  reply	other threads:[~2018-04-25 21:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25  0:09 [bug#31252] [PATCH] gnu: Add Ranger Eric Bavier
2018-04-25 21:09 ` Ludovic Courtès [this message]
2018-04-27  2:11   ` bug#31252: " Eric Bavier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87po2nngbw.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=31252@debbugs.gnu.org \
    --cc=ericbavier@centurylink.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).