From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40253)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fBRfx-00052F-QV
	for guix-patches@gnu.org; Wed, 25 Apr 2018 17:10:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fBRfu-0007cS-L4
	for guix-patches@gnu.org; Wed, 25 Apr 2018 17:10:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:59947)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fBRfu-0007c5-IY
	for guix-patches@gnu.org; Wed, 25 Apr 2018 17:10:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fBRfu-0008RM-CA
	for guix-patches@gnu.org; Wed, 25 Apr 2018 17:10:02 -0400
Subject: [bug#31252] [PATCH] gnu: Add Ranger.
Resent-Message-ID: <handler.31252.B31252.152469058832416@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
In-Reply-To: <1758300649.33991901.1524614953172.JavaMail.zimbra@centurylink.net>
	(Eric Bavier's message of "Tue, 24 Apr 2018 20:09:13 -0400 (EDT)")
References: <1758300649.33991901.1524614953172.JavaMail.zimbra@centurylink.net>
Date: Wed, 25 Apr 2018 23:09:39 +0200
Message-ID: <87po2nngbw.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Eric Bavier <ericbavier@centurylink.net>
Cc: 31252@debbugs.gnu.org

Eric Bavier <ericbavier@centurylink.net> skribis:

> From 03abb95c7e551ea45d0742bf72cb78e5f0ce210e Mon Sep 17 00:00:00 2001
> From: Eric Bavier <ericbavier@centurylink.net>
> Date: Tue, 24 Apr 2018 18:44:38 -0500
> Subject: [PATCH] gnu: Add Ranger.
> To: guix-patches@gnu.org
>
> From: Eric Bavier <bavier@member.fsf.org>
>
> * gnu/packages/disk.scm (ranger): New variable.

[...]

> +(define-public ranger
> +  (package
> +    (name "ranger")
> +    (version "1.9.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://ranger.github.io/"
> +                                  "ranger-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "1lnzkrxcnlwnyi3z0v8ybyp8d5rm26qm35rr68kbs2lbs06inha0"))))

Patch was mangled.  :-)

> +    (build-system python-build-system)
> +    (native-inputs                      ;for tests
> +     `(("python-pytest" ,python-pytest)
> +       ("python-pylint" ,python-pylint)
> +       ("python-flake8" ,python-flake8)
> +       ("which" ,which)))
> +    (arguments
> +     '(#:phases (modify-phases %standard-phases
> +                  (replace 'check
> +                    (lambda _ (invoke "make" "test"))))))

You can use #:test-target "test" instead.

> +    (home-page "https://ranger.github.io/")
> +    (synopsis "Console file manager")
> +    (description "@code{ranger} is a console file manager with VI key

Nitpick: =E2=80=9CRanger=E2=80=9D (or =E2=80=9Cranger=E2=80=9D?) and =E2=80=
=9CVi=E2=80=9D.

I haven=E2=80=99t tried using it, but otherwise LGTM.  Thanks!

Ludo=E2=80=99.