From: Eric Bavier <ericbavier@centurylink.net>
To: 31252-done@debbugs.gnu.org
Subject: bug#31252: [PATCH] gnu: Add Ranger.
Date: Thu, 26 Apr 2018 21:11:13 -0500 [thread overview]
Message-ID: <20180426211113.025b02cb@centurylink.net> (raw)
In-Reply-To: <87po2nngbw.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Wed, 25 Apr 2018 23:09:39 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Eric Bavier <ericbavier@centurylink.net> skribis:
>
> > + (arguments
> > + '(#:phases (modify-phases %standard-phases
> > + (replace 'check
> > + (lambda _ (invoke "make" "test"))))))
>
> You can use #:test-target "test" instead.
>
> > + (home-page "https://ranger.github.io/")
> > + (synopsis "Console file manager")
> > + (description "@code{ranger} is a console file manager with VI key
>
> Nitpick: “Ranger” (or “ranger”?) and “Vi”.
>
> I haven’t tried using it, but otherwise LGTM. Thanks!
Thanks for the review.
Pushed in 834b0b9a5ca7ebd2cd3c1b2fe8dcb99e5e2f0841 and
adfc742c420f34ecf925ea00d49204f9863bce33 (forgot to apply fixes before pushing ... oops).
`~Eric
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-04-27 2:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 0:09 [bug#31252] [PATCH] gnu: Add Ranger Eric Bavier
2018-04-25 21:09 ` Ludovic Courtès
2018-04-27 2:11 ` Eric Bavier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426211113.025b02cb@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=31252-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).