* [bug#61065] [PATCH] gnu: Add emacs-ein.
@ 2023-01-25 20:12 Cayetano Santos via Guix-patches via
2023-01-27 8:47 ` Nicolas Goaziou
2023-01-27 10:02 ` [bug#61065] [PATCH v2] " Cayetano Santos via Guix-patches via
0 siblings, 2 replies; 4+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2023-01-25 20:12 UTC (permalink / raw)
To: 61065; +Cc: Cayetano Santos
* gnu/packages/emacs-xyz.scm (emacs-ein): New variable.
---
gnu/packages/emacs-xyz.scm | 42 ++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dc378581f5..30633bd52c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34326,6 +34326,48 @@ (define-public emacs-code-cells
execute code split into cells according to certain magic comments.")
(license license:gpl3+))))
+(define-public emacs-ein
+ (package
+ (name "emacs-ein")
+ (version "20220911")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/millejoh/emacs-ipython-notebook")
+ (commit "b2410dc96f61aa806a7934099d8f1e40c8f6ca18")))
+ (sha256
+ (base32
+ "02392bxl0msda58cls0i79mzqjs73x39czx0mlb0sg2vxp84gy15"))))
+ (build-system emacs-build-system)
+ (arguments
+ (list #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'move-source-files
+ (lambda _
+ (let ((el-files (find-files "./lisp" ".*\\.el$")))
+ (for-each (lambda (f)
+ (rename-file f (basename f)))
+ el-files)))))))
+ (propagated-inputs (list emacs-websocket
+ emacs-anaphora
+ emacs-request
+ emacs-deferred
+ emacs-polymode
+ emacs-dash
+ emacs-with-editor))
+ (home-page "https://github.com/millejoh/emacs-ipython-notebook")
+ (synopsis "Jupyter client for all languages")
+ (description
+ "The Emacs IPython Notebook (EIN) package provides a Jupyter Notebook
+client and integrated REPL (like SLIME) in Emacs. EIN improves notebook
+editing by allowing you to use Emacs. It also expose IPython features such as
+code evaluation, object inspection and code completion. These features can be
+accessed anywhere in Emacs and improve Python code editing and reading in
+general in Emacs.")
+ (license license:gpl3+)))
+
(define-public emacs-kibit-helper
(package
(name "emacs-kibit-helper")
base-commit: 968b882f55c4d1009e62c603a860edfaee1609ad
--
2.39.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#61065] [PATCH] gnu: Add emacs-ein.
2023-01-25 20:12 [bug#61065] [PATCH] gnu: Add emacs-ein Cayetano Santos via Guix-patches via
@ 2023-01-27 8:47 ` Nicolas Goaziou
2023-01-27 10:02 ` [bug#61065] [PATCH v2] " Cayetano Santos via Guix-patches via
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2023-01-27 8:47 UTC (permalink / raw)
To: 61065; +Cc: csantosb
Hello,
Cayetano Santos via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-ein): New variable.
Thank you.
> + (propagated-inputs (list emacs-websocket
> + emacs-anaphora
> + emacs-request
> + emacs-deferred
> + emacs-polymode
> + emacs-dash
> + emacs-with-editor))
Could you order propagated inputs alphabetically?
Also, upstream provides tests. Is it feasible to run them, too?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#61065] [PATCH v2] gnu: Add emacs-ein.
2023-01-25 20:12 [bug#61065] [PATCH] gnu: Add emacs-ein Cayetano Santos via Guix-patches via
2023-01-27 8:47 ` Nicolas Goaziou
@ 2023-01-27 10:02 ` Cayetano Santos via Guix-patches via
2023-01-27 22:08 ` bug#61065: " Nicolas Goaziou
1 sibling, 1 reply; 4+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2023-01-27 10:02 UTC (permalink / raw)
To: 61065; +Cc: Cayetano Santos
* gnu/packages/emacs-xyz.scm (emacs-ein): New variable.
---
gnu/packages/emacs-xyz.scm | 50 ++++++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dc378581f5..087087444f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34326,6 +34326,56 @@ (define-public emacs-code-cells
execute code split into cells according to certain magic comments.")
(license license:gpl3+))))
+(define-public emacs-ein
+ (package
+ (name "emacs-ein")
+ (version "20220911")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/millejoh/emacs-ipython-notebook")
+ (commit "b2410dc96f61aa806a7934099d8f1e40c8f6ca18")))
+ (sha256
+ (base32
+ "02392bxl0msda58cls0i79mzqjs73x39czx0mlb0sg2vxp84gy15"))))
+ (build-system emacs-build-system)
+ (arguments
+ (list
+ #:tests? #t
+ #:test-command
+ #~(list "emacs" "-Q" "--batch"
+ "-L" "test"
+ "--load" "test/testein-loader.el")
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'move-source-files
+ (lambda _
+ (let ((el-files (find-files "./lisp" ".*\\.el$")))
+ (for-each (lambda (f)
+ (rename-file f (basename f)))
+ el-files)))))))
+ (native-inputs
+ (list emacs-f emacs-mocker))
+ (propagated-inputs (list emacs-anaphora
+ emacs-dash
+ emacs-deferred
+ emacs-polymode
+ emacs-request
+ emacs-websocket
+ emacs-with-editor))
+ (home-page "https://github.com/millejoh/emacs-ipython-notebook")
+ (synopsis "Jupyter client for all languages")
+ (description
+ "The Emacs IPython Notebook (EIN) package provides a Jupyter Notebook
+client and integrated REPL (like SLIME) in Emacs. EIN improves notebook
+editing by allowing you to use Emacs. It also expose IPython features such as
+code evaluation, object inspection and code completion. These features can be
+accessed anywhere in Emacs and improve Python code editing and reading in
+general in Emacs.")
+ (license license:gpl3+)))
+
(define-public emacs-kibit-helper
(package
(name "emacs-kibit-helper")
base-commit: 968b882f55c4d1009e62c603a860edfaee1609ad
--
2.39.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#61065: [PATCH v2] gnu: Add emacs-ein.
2023-01-27 10:02 ` [bug#61065] [PATCH v2] " Cayetano Santos via Guix-patches via
@ 2023-01-27 22:08 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2023-01-27 22:08 UTC (permalink / raw)
To: Cayetano Santos via Guix-patches via; +Cc: Cayetano Santos, 61065-done
Hello,
Cayetano Santos via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-ein): New variable.
Thank you. I applied your patch with the following changes.
> +(define-public emacs-ein
> + (package
> + (name "emacs-ein")
> + (version "20220911")
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/millejoh/emacs-ipython-notebook")
> + (commit "b2410dc96f61aa806a7934099d8f1e40c8f6ca18")))
I added
(file-name (git-file-name name version))
> + (sha256
> + (base32
> + "02392bxl0msda58cls0i79mzqjs73x39czx0mlb0sg2vxp84gy15"))))
> + (build-system emacs-build-system)
> + (arguments
> + (list
> + #:tests? #t
> + #:test-command
> + #~(list "emacs" "-Q" "--batch"
> + "-L" "test"
> + "--load" "test/testein-loader.el")
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'move-source-files
> + (lambda _
> + (let ((el-files (find-files "./lisp" ".*\\.el$")))
> + (for-each (lambda (f)
> + (rename-file f (basename f)))
> + el-files)))))))
> + (native-inputs
> + (list emacs-f emacs-mocker))
> + (propagated-inputs (list emacs-anaphora
> + emacs-dash
> + emacs-deferred
> + emacs-polymode
> + emacs-request
> + emacs-websocket
> + emacs-with-editor))
I added a newline character after "propagated-inputs".
> + (home-page "https://github.com/millejoh/emacs-ipython-notebook")
> + (synopsis "Jupyter client for all languages")
> + (description
> + "The Emacs IPython Notebook (EIN) package provides a Jupyter Notebook
> +client and integrated REPL (like SLIME) in Emacs. EIN improves notebook
> +editing by allowing you to use Emacs. It also expose IPython features such as
> +code evaluation, object inspection and code completion. These features can be
I added a missing space before "These features".
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-27 22:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-25 20:12 [bug#61065] [PATCH] gnu: Add emacs-ein Cayetano Santos via Guix-patches via
2023-01-27 8:47 ` Nicolas Goaziou
2023-01-27 10:02 ` [bug#61065] [PATCH v2] " Cayetano Santos via Guix-patches via
2023-01-27 22:08 ` bug#61065: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).