unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Cayetano Santos via Guix-patches via <guix-patches@gnu.org>
Cc: Cayetano Santos <csantosb@inventati.org>, 61065-done@debbugs.gnu.org
Subject: bug#61065: [PATCH v2] gnu: Add emacs-ein.
Date: Fri, 27 Jan 2023 23:08:48 +0100	[thread overview]
Message-ID: <87v8krk4un.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <4bb02cb0d7b3be8181fb0b8197f13795f8a110e6.1674813757.git.csantosb@inventati.org> (Cayetano Santos via Guix-patches via's message of "Fri, 27 Jan 2023 11:02:41 +0100")

Hello,

Cayetano Santos via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ein): New variable.

Thank you. I applied your patch with the following changes.


> +(define-public emacs-ein
> +  (package
> +    (name "emacs-ein")
> +    (version "20220911")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/millejoh/emacs-ipython-notebook")
> +         (commit "b2410dc96f61aa806a7934099d8f1e40c8f6ca18")))

I added

  (file-name (git-file-name name version))

> +       (sha256
> +        (base32
> +         "02392bxl0msda58cls0i79mzqjs73x39czx0mlb0sg2vxp84gy15"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     (list
> +      #:tests? #t
> +      #:test-command
> +      #~(list "emacs" "-Q" "--batch"
> +              "-L" "test"
> +              "--load" "test/testein-loader.el")
> +      #:phases
> +           #~(modify-phases %standard-phases
> +               (add-after 'unpack 'move-source-files
> +                 (lambda _
> +                   (let ((el-files (find-files "./lisp" ".*\\.el$")))
> +                     (for-each (lambda (f)
> +                                 (rename-file f (basename f)))
> +                               el-files)))))))
> +    (native-inputs
> +     (list emacs-f emacs-mocker))
> +    (propagated-inputs (list emacs-anaphora
> +                             emacs-dash
> +                             emacs-deferred
> +                             emacs-polymode
> +                             emacs-request
> +                             emacs-websocket
> +                             emacs-with-editor))

I added a newline character after "propagated-inputs".

> +    (home-page "https://github.com/millejoh/emacs-ipython-notebook")
> +    (synopsis "Jupyter client for all languages")
> +    (description
> +     "The Emacs IPython Notebook (EIN) package provides a Jupyter Notebook
> +client and integrated REPL (like SLIME) in Emacs.  EIN improves notebook
> +editing by allowing you to use Emacs.  It also expose IPython features such as
> +code evaluation, object inspection and code completion. These features can be

I added a missing space before "These features".

Regards,
-- 
Nicolas Goaziou




      reply	other threads:[~2023-01-27 22:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 20:12 [bug#61065] [PATCH] gnu: Add emacs-ein Cayetano Santos via Guix-patches via
2023-01-27  8:47 ` Nicolas Goaziou
2023-01-27 10:02 ` [bug#61065] [PATCH v2] " Cayetano Santos via Guix-patches via
2023-01-27 22:08   ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8krk4un.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=61065-done@debbugs.gnu.org \
    --cc=csantosb@inventati.org \
    --cc=guix-patches@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).