unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrew Tropin <andrew@trop.in>
To: Sergey Trofimov <sarg@sarg.org.ru>, 62274-done@debbugs.gnu.org
Cc: paren@disroot.org, ludo@gnu.org, Sergey Trofimov <sarg@sarg.org.ru>
Subject: bug#62274: [PATCH] home: 'home-environment-with-provenance' uses the HE location info.
Date: Mon, 20 Mar 2023 10:52:55 +0400	[thread overview]
Message-ID: <87pm9352yg.fsf@trop.in> (raw)
In-Reply-To: <20230319154537.30463-1-sarg@sarg.org.ru>

[-- Attachment #1: Type: text/plain, Size: 1693 bytes --]

On 2023-03-19 16:45, Sergey Trofimov wrote:

> * gnu/home.scm (home-environment-with-provenance): Make `config-file`
> optional, with the default taken from the HE location info.
> ---
>  gnu/home.scm | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/home.scm b/gnu/home.scm
> index 6d3f705758..2fefe7ba53 100644
> --- a/gnu/home.scm
> +++ b/gnu/home.scm
> @@ -103,7 +103,21 @@ (define* (home-environment-derivation he)
>                                #:target-type home-service-type)))
>      (service-value home)))
>  
> -(define* (home-environment-with-provenance he config-file)
> +
> +(define (home-environment-configuration-file he)
> +  "Return the configuration file of HE, based on its 'location' field, or #f
> +if it could not be determined."
> +  (let ((file (and=> (home-environment-location he)
> +                     location-file)))
> +    (and file
> +         (or (and (string-prefix? "/" file) file)
> +             (search-path %load-path file)))))
> +
> +(define* (home-environment-with-provenance he
> +                                           #:optional
> +                                           (config-file
> +                                            (home-environment-configuration-file
> +                                             he)))
>    "Return a variant of HE that stores its own provenance information,
>  including CONFIG-FILE, if available.  This is achieved by adding an instance
>  of HOME-PROVENANCE-SERVICE-TYPE to its services."

Thank you for the patch, applied and pushed as
1f36534c7e8f2325bff4df5d37ecc811dc63fc38.

-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2023-03-20  6:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-19 15:45 [bug#62274] [PATCH] home: 'home-environment-with-provenance' uses the HE location info Sergey Trofimov
2023-03-20  6:52 ` Andrew Tropin [this message]
2023-03-20 17:33 ` Ludovic Courtès
2023-03-20 19:03   ` Sergey Trofimov
2023-03-21  9:44     ` Ludovic Courtès
2023-03-21 10:56     ` Andrew Tropin
2023-03-21 12:22       ` Sergey Trofimov
2023-03-21 13:38         ` Andrew Tropin
2023-03-21 18:18           ` Sergey Trofimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm9352yg.fsf@trop.in \
    --to=andrew@trop.in \
    --cc=62274-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=paren@disroot.org \
    --cc=sarg@sarg.org.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).