From: Andrew Tropin <andrew@trop.in>
To: "Sergey Trofimov" <sarg@sarg.org.ru>, "Ludovic Courtès" <ludo@gnu.org>
Cc: 62274@debbugs.gnu.org, paren@disroot.org
Subject: [bug#62274] [PATCH] home: 'home-environment-with-provenance' uses the HE location info.
Date: Tue, 21 Mar 2023 14:56:18 +0400 [thread overview]
Message-ID: <87edpiz831.fsf@trop.in> (raw)
In-Reply-To: <871qljs0ju.fsf@sarg.org.ru>
[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]
On 2023-03-20 20:03, Sergey Trofimov wrote:
> Hi Ludovic,
>
>> Hi Sergey and all,
>>
>> Sergey Trofimov <sarg@sarg.org.ru> skribis:
>>
>>> * gnu/home.scm (home-environment-with-provenance): Make
>>> `config-file`
>>> optional, with the default taken from the HE location info.
>>
>> [...]
>>
>>> +(define* (home-environment-with-provenance he
>>> + #:optional
>>> + (config-file
>>> +
>>> (home-environment-configuration-file
>>> + he)))
>>
>> AFAICS, there’s only one call site for
>> ‘home-environment-with-provenance’, and it passes two arguments.
>> Thus,
>> the default value added by this patch will never be used.
>>
>> Am I missing something?
>
> You're right, the new signature is not used anywhere yet. Though
> I'm working on a patch to embed home profiles in disk images
> produced with `guix system image`. That's where this method comes
> handy, see example usage:
>
> (image
> (inherit efi-disk-image)
> (operating-system (operating-system-with-provenance (load
> "./system.scm")))
> (inputs
> `(("guix-home"
> ,(home-environment-with-provenance (load "./home.scm")))))
> (partition-table-type 'gpt)
> (volatile-root? #false))
Also, take a look at this thread:
https://yhetil.org/63960cf762aec1ed2c4182f49cac66bc37fce2aa.camel@rdmp.org
and this prototype:
https://git.sr.ht/~abcdw/rde/tree/044de83e980b7038b87d27a090aef24229df85eb/src/gnu/services/home.scm#L1
It can be related to what you want to achieve, whithout modifying
image-related code.
--
Best regards,
Andrew Tropin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2023-03-21 10:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 15:45 [bug#62274] [PATCH] home: 'home-environment-with-provenance' uses the HE location info Sergey Trofimov
2023-03-20 6:52 ` bug#62274: " Andrew Tropin
2023-03-20 17:33 ` [bug#62274] " Ludovic Courtès
2023-03-20 19:03 ` Sergey Trofimov
2023-03-21 9:44 ` Ludovic Courtès
2023-03-21 10:56 ` Andrew Tropin [this message]
2023-03-21 12:22 ` Sergey Trofimov
2023-03-21 13:38 ` Andrew Tropin
2023-03-21 18:18 ` Sergey Trofimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edpiz831.fsf@trop.in \
--to=andrew@trop.in \
--cc=62274@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=paren@disroot.org \
--cc=sarg@sarg.org.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).