From: Sergey Trofimov <sarg@sarg.org.ru>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 62274@debbugs.gnu.org, paren@disroot.org, andrew@trop.in
Subject: [bug#62274] [PATCH] home: 'home-environment-with-provenance' uses the HE location info.
Date: Mon, 20 Mar 2023 20:03:00 +0100 [thread overview]
Message-ID: <871qljs0ju.fsf@sarg.org.ru> (raw)
In-Reply-To: <87bkknl443.fsf@gnu.org>
Hi Ludovic,
> Hi Sergey and all,
>
> Sergey Trofimov <sarg@sarg.org.ru> skribis:
>
>> * gnu/home.scm (home-environment-with-provenance): Make
>> `config-file`
>> optional, with the default taken from the HE location info.
>
> [...]
>
>> +(define* (home-environment-with-provenance he
>> + #:optional
>> + (config-file
>> +
>> (home-environment-configuration-file
>> + he)))
>
> AFAICS, there’s only one call site for
> ‘home-environment-with-provenance’, and it passes two arguments.
> Thus,
> the default value added by this patch will never be used.
>
> Am I missing something?
You're right, the new signature is not used anywhere yet. Though
I'm working on a patch to embed home profiles in disk images
produced with `guix system image`. That's where this method comes
handy, see example usage:
(image
(inherit efi-disk-image)
(operating-system (operating-system-with-provenance (load
"./system.scm")))
(inputs
`(("guix-home"
,(home-environment-with-provenance (load "./home.scm")))))
(partition-table-type 'gpt)
(volatile-root? #false))
next prev parent reply other threads:[~2023-03-20 19:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 15:45 [bug#62274] [PATCH] home: 'home-environment-with-provenance' uses the HE location info Sergey Trofimov
2023-03-20 6:52 ` bug#62274: " Andrew Tropin
2023-03-20 17:33 ` [bug#62274] " Ludovic Courtès
2023-03-20 19:03 ` Sergey Trofimov [this message]
2023-03-21 9:44 ` Ludovic Courtès
2023-03-21 10:56 ` Andrew Tropin
2023-03-21 12:22 ` Sergey Trofimov
2023-03-21 13:38 ` Andrew Tropin
2023-03-21 18:18 ` Sergey Trofimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qljs0ju.fsf@sarg.org.ru \
--to=sarg@sarg.org.ru \
--cc=62274@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=ludo@gnu.org \
--cc=paren@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).