* [bug#41552] [PATCH] gnu: Add remid-lv2. @ 2020-05-27 0:37 Alexandros Theodotou 2020-05-30 11:33 ` Marius Bakke 0 siblings, 1 reply; 4+ messages in thread From: Alexandros Theodotou @ 2020-05-27 0:37 UTC (permalink / raw) To: 41552 [-- Attachment #1.1: Type: text/plain, Size: 63 bytes --] Hi, This patch adds the reMID LV2 plugin. Thanks, Alex [-- Attachment #1.2: 0001-gnu-Add-remid-lv2.patch --] [-- Type: text/x-patch, Size: 2032 bytes --] From ba3a5a3d309e128cd87a4a4b0058b5088f522853 Mon Sep 17 00:00:00 2001 From: Alexandros Theodotou <alex@zrythm.org> Date: Wed, 27 May 2020 01:35:03 +0100 Subject: [PATCH] gnu: Add remid-lv2. * gnu/packages/music.scm (remid-lv2): new variable. --- gnu/packages/music.scm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index f01978d118..9cfda8e88c 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -5341,6 +5341,42 @@ hall reverb and a room reverb. Both are available as LV2 plugins as well as JACK standalone applications.") (license license:gpl3+))) +(define-public remid-lv2 + (package + (name "remid-lv2") + (version "0.3") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/ssj71/" + "reMID.lv2/archive/v" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "1kffpv90a967wwpsa0jb1jp5qnhf85m4ap8nfw8wih71rcrgg4h3")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f)) ; no tests included + (inputs + `(("glib" ,glib) + ("alsa-lib" ,alsa-lib) + ("jack" ,jack-1) + ("lv2" ,lv2))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (home-page "https://github.com/ssj71/reMID.lv2") + (synopsis + "MIDI-controlled implementation of the SID 6581 chip used in the +Commodore 64") + (description + "The 6581 SID chip is the sound chip used in the Commodore 64 computer. +reMID is a MIDI implementation of the 6581 SID chip using the reSID library +to provide a virtual SID-based synthesizer, controllable in real-time via +MIDI. It includes support for scripted instruments that allow complex sonic +control of the chip.") + (license license:gpl2))) + (define-public zlfo (package (name "zlfo") -- 2.26.2 [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#41552] [PATCH] gnu: Add remid-lv2. 2020-05-27 0:37 [bug#41552] [PATCH] gnu: Add remid-lv2 Alexandros Theodotou @ 2020-05-30 11:33 ` Marius Bakke 2020-07-08 19:43 ` Alexandros Theodotou 0 siblings, 1 reply; 4+ messages in thread From: Marius Bakke @ 2020-05-30 11:33 UTC (permalink / raw) To: Alexandros Theodotou, 41552 [-- Attachment #1: Type: text/plain, Size: 2127 bytes --] Alexandros Theodotou <alex@zrythm.org> writes: > Hi, > > This patch adds the reMID LV2 plugin. Thanks! [...] > +(define-public remid-lv2 > + (package > + (name "remid-lv2") > + (version "0.3") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/ssj71/" > + "reMID.lv2/archive/v" > + version ".tar.gz")) The GitHub /archive/ URLs are not stable: they might fall out of GitHubs cache and be regenerated, with different time stamps. So we should use git-fetch here instead. This is different from "/releases/", which are uploaded. Unfortunately GitHubs UI makes it difficult to tell the difference short of looking at the URL. > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "1kffpv90a967wwpsa0jb1jp5qnhf85m4ap8nfw8wih71rcrgg4h3")))) > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f)) ; no tests included > + (inputs > + `(("glib" ,glib) > + ("alsa-lib" ,alsa-lib) > + ("jack" ,jack-1) > + ("lv2" ,lv2))) Nit: we usually sort inputs. Helpful when there are dozens. > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (home-page "https://github.com/ssj71/reMID.lv2") > + (synopsis > + "MIDI-controlled implementation of the SID 6581 chip used in the > +Commodore 64") > + (description > + "The 6581 SID chip is the sound chip used in the Commodore 64 computer. > +reMID is a MIDI implementation of the 6581 SID chip using the reSID library > +to provide a virtual SID-based synthesizer, controllable in real-time via > +MIDI. It includes support for scripted instruments that allow complex sonic > +control of the chip.") Why yes, I know some of these words :-) would it make sense to define "SID" here with @acronym? > + (license license:gpl2))) This is actually GPL2+, because none of the source files say "version 2 only" (and some actually say explicitly GPL2-or-later). Can you send an updated patch? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#41552] [PATCH] gnu: Add remid-lv2. 2020-05-30 11:33 ` Marius Bakke @ 2020-07-08 19:43 ` Alexandros Theodotou 2020-07-21 21:06 ` bug#41552: " Marius Bakke 0 siblings, 1 reply; 4+ messages in thread From: Alexandros Theodotou @ 2020-07-08 19:43 UTC (permalink / raw) To: Marius Bakke, 41552 [-- Attachment #1.1: Type: text/plain, Size: 2670 bytes --] Hi, Thanks for the feedback. I fixed the patch although I'm not sure what to do with the description/summary - I don't know what those are either, I just know that it's a cool audio plugin. Feel free to edit it. Thanks, Alex On Sat, 2020-05-30 at 13:33 +0200, Marius Bakke wrote: > Alexandros Theodotou <alex@zrythm.org> writes: > > > Hi, > > > > This patch adds the reMID LV2 plugin. > > Thanks! > > [...] > > > +(define-public remid-lv2 > > + (package > > + (name "remid-lv2") > > + (version "0.3") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append "https://github.com/ssj71/" > > + "reMID.lv2/archive/v" > > + version ".tar.gz")) > > The GitHub /archive/ URLs are not stable: they might fall out of > GitHubs > cache and be regenerated, with different time stamps. So we should > use > git-fetch here instead. > > This is different from "/releases/", which are > uploaded. Unfortunately > GitHubs UI makes it difficult to tell the difference short of looking > at > the URL. > > > + (file-name (string-append name "-" version ".tar.gz")) > > + (sha256 > > + (base32 > > + "1kffpv90a967wwpsa0jb1jp5qnhf85m4ap8nfw8wih71rcrgg4h3" > > )))) > > + (build-system cmake-build-system) > > + (arguments > > + `(#:tests? #f)) ; no tests included > > + (inputs > > + `(("glib" ,glib) > > + ("alsa-lib" ,alsa-lib) > > + ("jack" ,jack-1) > > + ("lv2" ,lv2))) > > Nit: we usually sort inputs. Helpful when there are dozens. > > > + (native-inputs > > + `(("pkg-config" ,pkg-config))) > > + (home-page "https://github.com/ssj71/reMID.lv2") > > + (synopsis > > + "MIDI-controlled implementation of the SID 6581 chip used in > > the > > +Commodore 64") > > + (description > > + "The 6581 SID chip is the sound chip used in the Commodore > > 64 computer. > > +reMID is a MIDI implementation of the 6581 SID chip using the > > reSID library > > +to provide a virtual SID-based synthesizer, controllable in real- > > time via > > +MIDI. It includes support for scripted instruments that allow > > complex sonic > > +control of the chip.") > > Why yes, I know some of these words :-) would it make sense to define > "SID" here with @acronym? > > > + (license license:gpl2))) > > This is actually GPL2+, because none of the source files say "version > 2 > only" (and some actually say explicitly GPL2-or-later). > > Can you send an updated patch? [-- Attachment #1.2: 0001-gnu-Add-remid-lv2.patch --] [-- Type: text/x-patch, Size: 2034 bytes --] From 7cc536dfeeea735afb8e15f83c5eef8aac020c4f Mon Sep 17 00:00:00 2001 From: Alexandros Theodotou <alex@zrythm.org> Date: Wed, 8 Jul 2020 20:39:38 +0100 Subject: [PATCH] gnu: Add remid-lv2. * gnu/packages/music.scm (remid-lv2): New variable. --- gnu/packages/music.scm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index d0f5bee3a0..6042015dda 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -5419,6 +5419,42 @@ automation that comes as an LV2 plugin bundle with a custom UI.") (home-page "https://git.zrythm.org/cgit/ZLFO/") (license license:agpl3+))) +(define-public remid-lv2 + (package + (name "remid-lv2") + (version "0.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/ssj71/reMID.lv2.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "062kriniidsrhzwrf89kfxm9wb0cmgrl07asnlmgil8vcl7gl9y5")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f)) ; no tests included + (inputs + `(("alsa-lib" ,alsa-lib) + ("glib" ,glib) + ("jack" ,jack-1) + ("lv2" ,lv2))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (home-page "https://github.com/ssj71/reMID.lv2") + (synopsis + "MIDI-controlled implementation of the SID 6581 chip used in the +Commodore 64") + (description + "The 6581 SID chip is the sound chip used in the Commodore 64 computer. +reMID is a MIDI implementation of the 6581 SID chip using the reSID library +to provide a virtual SID-based synthesizer, controllable in real-time via +MIDI. It includes support for scripted instruments that allow complex sonic +control of the chip.") + (license license:gpl2+))) + (define-public vl1-emulator (package (name "vl1-emulator") -- 2.27.0 [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#41552: [PATCH] gnu: Add remid-lv2. 2020-07-08 19:43 ` Alexandros Theodotou @ 2020-07-21 21:06 ` Marius Bakke 0 siblings, 0 replies; 4+ messages in thread From: Marius Bakke @ 2020-07-21 21:06 UTC (permalink / raw) To: Alexandros Theodotou, 41552-done [-- Attachment #1: Type: text/plain, Size: 353 bytes --] Alexandros Theodotou <alex@zrythm.org> writes: > Hi, > > Thanks for the feedback. > > I fixed the patch although I'm not sure what to do with the > description/summary - I don't know what those are either, I just know > that it's a cool audio plugin. Feel free to edit it. OK. I applied the patch after fixing the indentation. Thanks! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-21 21:07 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-05-27 0:37 [bug#41552] [PATCH] gnu: Add remid-lv2 Alexandros Theodotou 2020-05-30 11:33 ` Marius Bakke 2020-07-08 19:43 ` Alexandros Theodotou 2020-07-21 21:06 ` bug#41552: " Marius Bakke
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).