From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QLyJC7JE0l4/YgAA0tVLHw (envelope-from ) for ; Sat, 30 May 2020 11:34:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UIxxB7JE0l4cfAAAB5/wlQ (envelope-from ) for ; Sat, 30 May 2020 11:34:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9A8399404CE for ; Sat, 30 May 2020 11:34:09 +0000 (UTC) Received: from localhost ([::1]:55228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jezkc-0000DW-W4 for larch@yhetil.org; Sat, 30 May 2020 07:34:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jezkY-0000DN-BA for guix-patches@gnu.org; Sat, 30 May 2020 07:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jezkY-0005DZ-1o for guix-patches@gnu.org; Sat, 30 May 2020 07:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jezkX-00070D-Vm for guix-patches@gnu.org; Sat, 30 May 2020 07:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41552] [PATCH] gnu: Add remid-lv2. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 30 May 2020 11:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41552 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexandros Theodotou , 41552@debbugs.gnu.org Received: via spool by 41552-submit@debbugs.gnu.org id=B41552.159083840826875 (code B ref 41552); Sat, 30 May 2020 11:34:01 +0000 Received: (at 41552) by debbugs.gnu.org; 30 May 2020 11:33:28 +0000 Received: from localhost ([127.0.0.1]:57007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jezk0-0006zP-BC for submit@debbugs.gnu.org; Sat, 30 May 2020 07:33:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jezjy-0006zD-Qq for 41552@debbugs.gnu.org; Sat, 30 May 2020 07:33:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33109) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jezjs-0004QK-Oh; Sat, 30 May 2020 07:33:20 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:40766 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jezjr-0004JZ-Jx; Sat, 30 May 2020 07:33:20 -0400 From: Marius Bakke In-Reply-To: <94c136949f58964383c2fabe6a28aa80bc3c79ea.camel@zrythm.org> References: <94c136949f58964383c2fabe6a28aa80bc3c79ea.camel@zrythm.org> Date: Sat, 30 May 2020 13:33:17 +0200 Message-ID: <87lfl93beq.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: CQgfMrGsMpgt --=-=-= Content-Type: text/plain Alexandros Theodotou writes: > Hi, > > This patch adds the reMID LV2 plugin. Thanks! [...] > +(define-public remid-lv2 > + (package > + (name "remid-lv2") > + (version "0.3") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/ssj71/" > + "reMID.lv2/archive/v" > + version ".tar.gz")) The GitHub /archive/ URLs are not stable: they might fall out of GitHubs cache and be regenerated, with different time stamps. So we should use git-fetch here instead. This is different from "/releases/", which are uploaded. Unfortunately GitHubs UI makes it difficult to tell the difference short of looking at the URL. > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "1kffpv90a967wwpsa0jb1jp5qnhf85m4ap8nfw8wih71rcrgg4h3")))) > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f)) ; no tests included > + (inputs > + `(("glib" ,glib) > + ("alsa-lib" ,alsa-lib) > + ("jack" ,jack-1) > + ("lv2" ,lv2))) Nit: we usually sort inputs. Helpful when there are dozens. > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (home-page "https://github.com/ssj71/reMID.lv2") > + (synopsis > + "MIDI-controlled implementation of the SID 6581 chip used in the > +Commodore 64") > + (description > + "The 6581 SID chip is the sound chip used in the Commodore 64 computer. > +reMID is a MIDI implementation of the 6581 SID chip using the reSID library > +to provide a virtual SID-based synthesizer, controllable in real-time via > +MIDI. It includes support for scripted instruments that allow complex sonic > +control of the chip.") Why yes, I know some of these words :-) would it make sense to define "SID" here with @acronym? > + (license license:gpl2))) This is actually GPL2+, because none of the source files say "version 2 only" (and some actually say explicitly GPL2-or-later). Can you send an updated patch? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7SRH0ACgkQoqBt8qM6 VPrwDQgAhfbM6fDn8enOodbKasKOuvelgAeq5C+y28Sx23P45uf2Qeh6b1r18wNG SeTmyRbyYwlG7nVBTa6+KyT/AbY0NGQPu9DRlww7Y20UbKrD2q6k4KOp9St1YFEv sr8l58VAcGfa4fldMnspQKpCH8rwKIO30mNutWOLrgjO6zIH0TSO5aa9z4EF8qkF iDTVDG/9/jOhIgZQsaGHNg9S8nNkp43ET/NQhXWs9Z7Cg52d/3Uv3SIV60cGLFRS VUx/iDb3x9Y6IKbyaPWxn00HgmPLd9iFXl8rC5OSwfijgqnnppF5OOSXXXUvmHbg /XuTptc+dePD3l3WNjdv+qBMLQMBGA== =xp0n -----END PGP SIGNATURE----- --=-=-=--