unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>, Roel Janssen <roel@gnu.org>,
	44613@debbugs.gnu.org
Subject: [bug#44613] [PATCH] Fix build for bedtools
Date: Fri, 13 Nov 2020 16:08:27 +0100	[thread overview]
Message-ID: <87o8k1b8gk.fsf@gnu.org> (raw)
In-Reply-To: <86k0upe5yp.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

zimoun <zimon.toutoune@gmail.com> writes:

> PS:
> I am always confused if the removal should be done in ’origin’ or in the
> ’add-after 'unpack’ phase; especially when the bundle is free software.
> Other said, what should an user expect when fetching with “guix build -S”?
> Anyway! :-)

Unbundling is always better to do in a snippet.  It leads to less
bandwidth usage, and users can more easily inspect the (actual) code.

For other kinds of patching the boundary is less clear.  Generally,
Guix-specific tweaks should be in a phase, but "universal" bug fixes may
well be in a snippet.

I sometimes imagine a downstream distribution that use Guix sources, but
not the build scripts, to draw the line.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

  parent reply	other threads:[~2020-11-13 15:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 11:01 [bug#44613] [PATCH] Fix build for bedtools Roel Janssen
2020-11-13 12:39 ` zimoun
2020-11-13 12:55   ` Roel Janssen
2020-11-13 13:34     ` zimoun
2020-11-13 14:00       ` bug#44613: " Roel Janssen
2020-11-13 15:08       ` Marius Bakke [this message]
2020-11-13 15:51         ` [bug#44613] what “guix build -S” should return? zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8k1b8gk.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=44613@debbugs.gnu.org \
    --cc=roel@gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).