From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mOPaEpihrl8MQQAA0tVLHw (envelope-from ) for ; Fri, 13 Nov 2020 15:09:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6PenDpihrl+BSwAAbx9fmQ (envelope-from ) for ; Fri, 13 Nov 2020 15:09:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB1B0940237 for ; Fri, 13 Nov 2020 15:09:11 +0000 (UTC) Received: from localhost ([::1]:59418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdahJ-0004vE-L6 for larch@yhetil.org; Fri, 13 Nov 2020 10:09:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdahC-0004v3-PJ for guix-patches@gnu.org; Fri, 13 Nov 2020 10:09:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37521) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdahC-0000Jb-FG for guix-patches@gnu.org; Fri, 13 Nov 2020 10:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kdahC-0003md-AT for guix-patches@gnu.org; Fri, 13 Nov 2020 10:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44613] [PATCH] Fix build for bedtools Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 13 Nov 2020 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44613 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun , Roel Janssen , 44613@debbugs.gnu.org Received: via spool by 44613-submit@debbugs.gnu.org id=B44613.160528011814513 (code B ref 44613); Fri, 13 Nov 2020 15:09:02 +0000 Received: (at 44613) by debbugs.gnu.org; 13 Nov 2020 15:08:38 +0000 Received: from localhost ([127.0.0.1]:49067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdago-0003m1-5a for submit@debbugs.gnu.org; Fri, 13 Nov 2020 10:08:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdagm-0003lp-Qp for 44613@debbugs.gnu.org; Fri, 13 Nov 2020 10:08:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60936) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdagh-00008N-Gt; Fri, 13 Nov 2020 10:08:31 -0500 Received: from host-37-191-236-253.lynet.no ([37.191.236.253]:56640 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdagg-0004rp-1J; Fri, 13 Nov 2020 10:08:30 -0500 From: Marius Bakke In-Reply-To: <86k0upe5yp.fsf@gmail.com> References: <86v9e9e8gz.fsf@gmail.com> <695715d9f08a7ec06b6dfe8bcf71173829a0d029.camel@gnu.org> <86k0upe5yp.fsf@gmail.com> Date: Fri, 13 Nov 2020 16:08:27 +0100 Message-ID: <87o8k1b8gk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.61 X-TUID: NzPiUKQboZAV --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable zimoun writes: > PS: > I am always confused if the removal should be done in =E2=80=99origin=E2= =80=99 or in the > =E2=80=99add-after 'unpack=E2=80=99 phase; especially when the bundle is = free software. > Other said, what should an user expect when fetching with =E2=80=9Cguix b= uild -S=E2=80=9D? > Anyway! :-) Unbundling is always better to do in a snippet. It leads to less bandwidth usage, and users can more easily inspect the (actual) code. For other kinds of patching the boundary is less clear. Generally, Guix-specific tweaks should be in a phase, but "universal" bug fixes may well be in a snippet. I sometimes imagine a downstream distribution that use Guix sources, but not the build scripts, to draw the line. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCgAtFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl+uoWsPHG1hcml1c0Bn bnUub3JnAAoJEKKgbfKjOlT6u5YH/izJ3w/QKYfoL97jfU83PDBlEETIpp/S5wZT ExBEA+pTy7UucE4b4AWBuR3TH56SEi6cVr+N1poHzngOrisPovASE1ZCv6pUk4sv EEf3jUBIEuruS5le/5Ihg3lQu8KcyIypUvOKUl+X4FMSgzHxdAdUll0rvdQwVswb bjEC9B730jpbPMWTEEK62VnHoE5AD5LIJgG//kCxgUjXDaBTNih2NN5ihCuEC4NE nbcbadCtZxXMI0aOpSOEylWbAM/h0ydDoceTyru+WpZvKLaPUKRIDzVInPO5givx elS/RIj2nFHgT49KUDZVuMEszXvbf3zKwyphn/UK2zU/uB03l9Q= =H285 -----END PGP SIGNATURE----- --=-=-=--