From: zimoun <zimon.toutoune@gmail.com>
To: Roel Janssen <roel@gnu.org>, 44613@debbugs.gnu.org
Subject: [bug#44613] [PATCH] Fix build for bedtools
Date: Fri, 13 Nov 2020 14:34:06 +0100 [thread overview]
Message-ID: <86k0upe5yp.fsf@gmail.com> (raw)
In-Reply-To: <695715d9f08a7ec06b6dfe8bcf71173829a0d029.camel@gnu.org>
Hi Roel,
On Fri, 13 Nov 2020 at 13:55, Roel Janssen <roel@gnu.org> wrote:
> I also tried removing the bundled htslib for bedtools, but didn't go
> this route for two reasons:
> - The bundled htslib for bedtools seems "slightly modified" (I didn't
> investigate further)
> - Replacing the references to libhts.a with $(pkg-config htslib --
> cflags --libs) produced various linker errors. So I stopped right
> there.
>
> I'm sure more tools will likely have failed because of the htslib
> upgrade (sorry about this!), so having htslib-1.9 around for some time
> may be a good fallback for now.
Thank for your explanations.
> Just to double-check: Is it OK to push the proposed patches?
I have not tried them but they LGTM.
All the best,
simon
PS:
I am always confused if the removal should be done in ’origin’ or in the
’add-after 'unpack’ phase; especially when the bundle is free software.
Other said, what should an user expect when fetching with “guix build -S”?
Anyway! :-)
next prev parent reply other threads:[~2020-11-13 13:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 11:01 [bug#44613] [PATCH] Fix build for bedtools Roel Janssen
2020-11-13 12:39 ` zimoun
2020-11-13 12:55 ` Roel Janssen
2020-11-13 13:34 ` zimoun [this message]
2020-11-13 14:00 ` bug#44613: " Roel Janssen
2020-11-13 15:08 ` [bug#44613] " Marius Bakke
2020-11-13 15:51 ` [bug#44613] what “guix build -S” should return? zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k0upe5yp.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=44613@debbugs.gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).