From: Christopher Baines <mail@cbaines.net>
To: jgart <jgart@dismail.de>
Cc: 59417-done@debbugs.gnu.org, 59417@debbugs.gnu.org
Subject: [bug#59417] [PATCH] gnu: Add emacs-on.
Date: Mon, 21 Nov 2022 14:40:58 +0000 [thread overview]
Message-ID: <87o7t0tlh0.fsf@cbaines.net> (raw)
In-Reply-To: <20221120183931.14423-1-jgart@dismail.de>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
jgart via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-on): New variable.
> ---
> gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
Thanks, I've pushed this to master as
f0cc7542f535cd0ccb75352cabc465a8dc1b1551.
Note that I did move the package definition to not be so close to the
bottom of the module. Thanks for following the comment and not putting
it right at the bottom, but the other important bit is "place them above
by existing packages with similar functionality or similar names".
The intent with that is to avoid Git conflicts when several packages are
added in the same place. For example, you also sent this patch
https://issues.guix.gnu.org/59429 that adds emacs-ukrainian-holidays in
the same place. That's just asking for Git trouble!
I normally just search for the start of the package name, e.g. emacs-o
and then find a similarly named package to place the new one by,
e.g. emacs-on-screen in this case.
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2022-11-21 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 18:39 [bug#59417] [PATCH] gnu: Add emacs-on jgart via Guix-patches via
2022-11-21 14:40 ` Christopher Baines [this message]
2022-11-27 18:23 ` jgart via Guix-patches via
2022-11-27 18:26 ` ( via Guix-patches via
2022-11-27 18:32 ` jgart via Guix-patches via
2022-11-27 18:51 ` ( via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7t0tlh0.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=59417-done@debbugs.gnu.org \
--cc=59417@debbugs.gnu.org \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).