unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: jgart via Guix-patches via <guix-patches@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 59417-done@debbugs.gnu.org, 59417@debbugs.gnu.org
Subject: [bug#59417] [PATCH] gnu: Add emacs-on.
Date: Sun, 27 Nov 2022 12:23:16 -0600	[thread overview]
Message-ID: <20221127122316.GB8668@dismail.de> (raw)
In-Reply-To: <87o7t0tlh0.fsf@cbaines.net>

On Mon, 21 Nov 2022 14:40:58 +0000 Christopher Baines <mail@cbaines.net> wrote:
> Thanks, I've pushed this to master as
> f0cc7542f535cd0ccb75352cabc465a8dc1b1551.

Thanks!

> Note that I did move the package definition to not be so close to the
> bottom of the module. Thanks for following the comment and not putting
> it right at the bottom, but the other important bit is "place them above
> by existing packages with similar functionality or similar names".
> 
> The intent with that is to avoid Git conflicts when several packages are
> added in the same place. For example, you also sent this patch
> https://issues.guix.gnu.org/59429 that adds emacs-ukrainian-holidays in
> the same place. That's just asking for Git trouble!

Sorry about that! I'll keep it in mind for future patch sets. I think I'll
just start putting stuff in alphabetical order to avoid this altogether.

all best,

jgart




  reply	other threads:[~2022-11-27 18:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-20 18:39 [bug#59417] [PATCH] gnu: Add emacs-on jgart via Guix-patches via
2022-11-21 14:40 ` Christopher Baines
2022-11-27 18:23   ` jgart via Guix-patches via [this message]
2022-11-27 18:26     ` ( via Guix-patches via
2022-11-27 18:32       ` jgart via Guix-patches via
2022-11-27 18:51         ` ( via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221127122316.GB8668@dismail.de \
    --to=guix-patches@gnu.org \
    --cc=59417-done@debbugs.gnu.org \
    --cc=59417@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).