From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wLhGGD+Pe2PJsAAAbAwnHQ (envelope-from ) for ; Mon, 21 Nov 2022 15:46:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CG0nGD+Pe2MGSQEAauVa8A (envelope-from ) for ; Mon, 21 Nov 2022 15:46:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CF27BBED for ; Mon, 21 Nov 2022 15:46:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox83n-0004Ew-DE; Mon, 21 Nov 2022 09:46:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox83f-0004Dp-Gg for guix-patches@gnu.org; Mon, 21 Nov 2022 09:46:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ox83e-0006ck-RN for guix-patches@gnu.org; Mon, 21 Nov 2022 09:46:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ox83e-0004rH-A0 for guix-patches@gnu.org; Mon, 21 Nov 2022 09:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59417] [PATCH] gnu: Add emacs-on. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Nov 2022 14:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59417 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart Cc: 59417-done@debbugs.gnu.org, 59417@debbugs.gnu.org X-Debbugs-Original-Cc: 59417-done@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166904195518655 (code B ref -1); Mon, 21 Nov 2022 14:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Nov 2022 14:45:55 +0000 Received: from localhost ([127.0.0.1]:45973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox83W-0004qo-NS for submit@debbugs.gnu.org; Mon, 21 Nov 2022 09:45:54 -0500 Received: from lists.gnu.org ([209.51.188.17]:43308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox83U-0004qg-Uh for submit@debbugs.gnu.org; Mon, 21 Nov 2022 09:45:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox83T-00048R-Cr for guix-patches@gnu.org; Mon, 21 Nov 2022 09:45:52 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox83F-0006Hl-Dn for guix-patches@gnu.org; Mon, 21 Nov 2022 09:45:41 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id F121027BBE9; Mon, 21 Nov 2022 14:45:35 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id abd3a6c9; Mon, 21 Nov 2022 14:45:35 +0000 (UTC) References: <20221120183931.14423-1-jgart@dismail.de> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines Date: Mon, 21 Nov 2022 14:40:58 +0000 In-reply-to: <20221120183931.14423-1-jgart@dismail.de> Message-ID: <87o7t0tlh0.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669041983; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=5eOentPhAUo2SyFjGgoOr4eDx9NUTzmgCAXZyCrN6Oo=; b=NWzPyUDZm9A7/Zp5c123AUjczgmU/bcnAGWeYDeCG1OJZIgFiahTZed3CU3PPkuHiAThhT Xl691KQF8aM+kkQ5oeILKn1s9U9DfstrrpqjrXhgytadq5FfnA6dgJKWOZ9n4KaHswoiNK 7l2mihIM5nsDrxsaQt2krWlunD2clGEqy+SceuSqRhT7btOPYSSv1655rwz7qNAl6Xq0Hi Qv5iS0VA5so1giWaJWc+jrSWutGfgDX2xXj8Ib32+hCANmAFqH3CCXO3hHyZ089K8ab4m/ QyCESdgSnLBcHXchcRltUjdO4SxOdbpTk/XOkmUsSmmUSkqX0uKz+/RY9+H3lg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669041983; a=rsa-sha256; cv=none; b=QMpi/+xVjmKtokI5oghgBgsJYpmvGb4oWDeclD90mJEru8B6WA3a1AHfYnA6VBOHjHaOcL Dr1NiPy12t7UjZfPruUyJQYlftgwX/ASKuc0eFPJpk9J8//FPTPgLFUIFX4N4fhv03G3aJ n8Hj+x912SvI+saSmuoMO4IP/CTdFilmZwmhuHd5BOrB/UqBk6ZWgHjLeLq5kLsOD1YAMw vitzH/ZdQcOefywms4zlMYrEItb+GmE9lVAGn7k+jmm317gEDDz69pDZo+2znAvuD2xA4j DUtJ44hwP/reFOIN1gzqRO6wM5qS8f8KTRxmCR5gBwErd6/BdRO+kWmN9WAnsw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2CF27BBED X-Spam-Score: -6.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: uPzaeq38fZe4 --=-=-= Content-Type: text/plain jgart via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-on): New variable. > --- > gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) Thanks, I've pushed this to master as f0cc7542f535cd0ccb75352cabc465a8dc1b1551. Note that I did move the package definition to not be so close to the bottom of the module. Thanks for following the comment and not putting it right at the bottom, but the other important bit is "place them above by existing packages with similar functionality or similar names". The intent with that is to avoid Git conflicts when several packages are added in the same place. For example, you also sent this patch https://issues.guix.gnu.org/59429 that adds emacs-ukrainian-holidays in the same place. That's just asking for Git trouble! I normally just search for the start of the package name, e.g. emacs-o and then find a similarly named package to place the new one by, e.g. emacs-on-screen in this case. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmN7jwtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfmgQ/+P44sRA2i8x40IW406w3MfaHKQyHVba15 rVQaSzNIy0N5GiarAdNmOvpAdVMmrWLmCgJ6KRgDNJx4J6IijmddXf8UPM9oKaY4 HC6SGqbSVsrBsuX6Ch27My6j1eXw75ee11cXX/PGrxotZdI+eg3JE2M0Ft7m0OvC WT8EgfQKN43IM3hw0qslB6llV/7vbJuqLTVZCLozjb0/qA2ld8o2VR16OoCsRiPE p3QFbmqbp0ocDi8dydt95yY1n8hY6QPSMoBTZu8Pxgod/FfXmtlibZkQauTt2cvn aRdFNG6eD2AmA7WciJnAzNp48Eg0/TWT39SpW4hmWCBhmBZZ/d5DJZaFkyadNgLV ivntsXg7hmuHrxfzexGBJ7Ozs4tSSAMpIcKp5YgWDru9mM8M8DDiI9d3WrJUPCUc VMgG/v/4Q9V4fifnnhRq8vyBdUa0/2qGOAP4F7DUeTrfpq97K+NPZ1dEzhEtnKVp G+iy8+IBlC/NYUPWCjmDDoJsPpkGD329HiCQFdYyigJZt0qXpdhem6HmyxXUmH4F ZeOzQAqXG9r6xRdKO/uTBFBhC1Uz8VPLl2c72Gd0Ld7JYIfgCP/rxr9llA7+ku6b RllA7iDmWuMUueB+1Qg3JpzrDGu3HdSTL8g564f1uoesQ7TYx3q6K4DoNq+xQOnP 2SJlimyVyKw= =WBjy -----END PGP SIGNATURE----- --=-=-=--