unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#36807] remove obsolete broken haskell packages
@ 2019-07-25 11:40 Robert Vollmert
  2019-07-25 11:45 ` [bug#36807] [PATCH] gnu: Remove ghc-regex-tdfa-rc (broken and unused) Robert Vollmert
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Robert Vollmert @ 2019-07-25 11:40 UTC (permalink / raw)
  To: 36807

This series removes some outdated packages that don’t build and
aren’t depend on.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#36807] [PATCH] gnu: Remove ghc-regex-tdfa-rc (broken and unused)
  2019-07-25 11:40 [bug#36807] remove obsolete broken haskell packages Robert Vollmert
@ 2019-07-25 11:45 ` Robert Vollmert
  2019-07-25 11:46 ` [bug#36807] [PATCH] gnu: Remove ghc-haddock-test " Robert Vollmert
  2019-07-25 13:29 ` [bug#36807] remove obsolete broken haskell packages Timothy Sample
  2 siblings, 0 replies; 6+ messages in thread
From: Robert Vollmert @ 2019-07-25 11:45 UTC (permalink / raw)
  To: 36807; +Cc: Robert Vollmert

It doesn't build, has no reverse dependencies, and is deprecated
upstream.

* gnu/packages/haskell.scm (ghc-regex-tdfa-rc): Remove package.
---
 gnu/packages/haskell.scm | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index d8c574b3f5..c5de8f2c10 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -3033,30 +3033,6 @@ Haskell library @code{regex-base}.")
 @code{regex-posix} to replace @code{Text.Regex}.")
     (license license:bsd-3)))
 
-(define-public ghc-regex-tdfa-rc
-  (package
-    (name "ghc-regex-tdfa-rc")
-    (version "1.1.8.3")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append
-             "https://hackage.haskell.org/package/regex-tdfa-rc/regex-tdfa-rc-"
-             version
-             ".tar.gz"))
-       (sha256
-        (base32
-         "1vi11i23gkkjg6193ak90g55akj69bhahy542frkwb68haky4pp3"))))
-    (build-system haskell-build-system)
-    (inputs
-     `(("ghc-regex-base" ,ghc-regex-base)))
-    (home-page
-     "https://hackage.haskell.org/package/regex-tdfa")
-    (synopsis "Tagged DFA regex engine for Haskell")
-    (description "A new all-Haskell \"tagged\" DFA regex engine, inspired by
-@code{libtre} (fork by Roman Cheplyaka).")
-    (license license:bsd-3)))
-
 (define-public ghc-regex-tdfa-text
   (package
     (name "ghc-regex-tdfa-text")
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#36807] [PATCH] gnu: Remove ghc-haddock-test (broken and unused)
  2019-07-25 11:40 [bug#36807] remove obsolete broken haskell packages Robert Vollmert
  2019-07-25 11:45 ` [bug#36807] [PATCH] gnu: Remove ghc-regex-tdfa-rc (broken and unused) Robert Vollmert
@ 2019-07-25 11:46 ` Robert Vollmert
  2019-07-25 13:29 ` [bug#36807] remove obsolete broken haskell packages Timothy Sample
  2 siblings, 0 replies; 6+ messages in thread
From: Robert Vollmert @ 2019-07-25 11:46 UTC (permalink / raw)
  To: 36807; +Cc: Robert Vollmert

The package doesn't build, has no reverse dependencies, and is
deprecated upstream.

* gnu/packages/haskell.scm (ghc-haddock-test): Remove packge.
---
 gnu/packages/haskell.scm | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index c5de8f2c10..bf1d1669f5 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -1184,28 +1184,6 @@ the ‘haddock’ package.")
 documentation-generation tool for Haskell libraries.")
     (license license:bsd-3)))
 
-(define-public ghc-haddock-test
-  (package
-    (name "ghc-haddock-test")
-    (version "0.0.1")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "https://hackage.haskell.org/package/"
-                           "haddock-test/haddock-test-"
-                           version ".tar.gz"))
-       (sha256
-        (base32
-         "1ax8fnfrwx66csj952f3virxzapipan9da7z5l1zc12nqkifbs7w"))))
-    (build-system haskell-build-system)
-    (inputs
-     `(("ghc-xml" ,ghc-xml)
-       ("ghc-syb" ,ghc-syb)))
-    (home-page "http://www.haskell.org/haddock/")
-    (synopsis "Test utilities for Haddock")
-    (description "This package provides test utilities for Haddock.")
-    (license license:bsd-3)))
-
 (define-public ghc-haddock
   (package
     (name "ghc-haddock")
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#36807] remove obsolete broken haskell packages
  2019-07-25 11:40 [bug#36807] remove obsolete broken haskell packages Robert Vollmert
  2019-07-25 11:45 ` [bug#36807] [PATCH] gnu: Remove ghc-regex-tdfa-rc (broken and unused) Robert Vollmert
  2019-07-25 11:46 ` [bug#36807] [PATCH] gnu: Remove ghc-haddock-test " Robert Vollmert
@ 2019-07-25 13:29 ` Timothy Sample
  2019-08-01 16:23   ` [bug#36807] Please merge wip-haskell-updates (Re: [bug#36807] remove obsolete broken haskell packages) Robert Vollmert
  2 siblings, 1 reply; 6+ messages in thread
From: Timothy Sample @ 2019-07-25 13:29 UTC (permalink / raw)
  To: Robert Vollmert; +Cc: 36807

Hi Robert,

Robert Vollmert <rob@vllmrt.net> writes:

> This series removes some outdated packages that don’t build and
> aren’t depend on.

I remember that we intended to remove these last year.  Indeed, Ricardo
mentioned it when we were finishing up the upgrade to GHC 8.4:

    https://lists.gnu.org/archive/html/guix-devel/2018-09/msg00330.html

Based on that, we could also get rid of “ghc-packedstring” if it doesn’t
have any dependants.

Now for my usual commit message nit-picking.  :)  You should drop the
parenthetical “broken and unused” note and add a period to the end of
the first line, like this:

    gnu: Remove ghc-regex-tdfa-rc.

One of the commits says “It...” and the other says “This package...”.
They might as well be the same.  Lastly, it’s usually “remove variable”
instead of “remove package”.

Other than that, LGTM.  Thanks!  (Do you have commit access now or
should I push these?)


-- Tim

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#36807] Please merge wip-haskell-updates (Re: [bug#36807] remove obsolete broken haskell packages)
  2019-07-25 13:29 ` [bug#36807] remove obsolete broken haskell packages Timothy Sample
@ 2019-08-01 16:23   ` Robert Vollmert
       [not found]     ` <87mugmq5ll.fsf@ngyro.com>
  0 siblings, 1 reply; 6+ messages in thread
From: Robert Vollmert @ 2019-08-01 16:23 UTC (permalink / raw)
  To: guix-devel; +Cc: 36807

Hi all, Timothy,

On 25. Jul 2019, at 15:29, Timothy Sample <samplet@ngyro.com> wrote:
> Other than that, LGTM.  Thanks!  (Do you have commit access now or
> should I push these?)

I do have commit access now, but for the moment I’m keeping to the
branch wip-haskell-updates.

Thus, I’d ask you (or someone) to merge that (or the parts you deem
appropriate). I’ve incorporated your comments, and removed
ghc-packedstring. In addition, the branch incorporates some other
patchsets:

#36493: updating GHC-included haskell dependencies (this one is already
        in core-updates)
#36562: downgrade ansi-terminal to be compatible with the package set
#36663: adding elm compiler dependencies (just a few extra ghc packages)
#36692: GHC version 8.6.5 (just as a package for now, not used to build
        anything)
#36807: this bug report, removing three deprecated packages
no ticket: Skip tests for three Haskell packages that fail on i686 only
        (and seem harmless): ghc-trifecta, ghc-yaml, ghc-libmpd-haskell.

Cheers
Robert

> Hi Robert,
> 
> Robert Vollmert <rob@vllmrt.net> writes:
> 
>> This series removes some outdated packages that don’t build and
>> aren’t depend on.
> 
> I remember that we intended to remove these last year.  Indeed, Ricardo
> mentioned it when we were finishing up the upgrade to GHC 8.4:
> 
>    https://lists.gnu.org/archive/html/guix-devel/2018-09/msg00330.html
> 
> Based on that, we could also get rid of “ghc-packedstring” if it doesn’t
> have any dependants.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#36807: Please merge wip-haskell-updates (Re: [bug#36807] remove obsolete broken haskell packages)
       [not found]         ` <878ss4pbkg.fsf@ngyro.com>
@ 2019-08-08  4:28           ` Timothy Sample
  0 siblings, 0 replies; 6+ messages in thread
From: Timothy Sample @ 2019-08-08  4:28 UTC (permalink / raw)
  To: Robert Vollmert; +Cc: 36807-done

Timothy Sample <samplet@ngyro.com> writes:

> Hi Robert,
>
> I pushed my touched-up version of your branch to master!  (See commits
> a62ddb748f–caa366ec23.)  Now I will enjoy closing all those patches.  :)

Including this one!

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-08-08  4:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25 11:40 [bug#36807] remove obsolete broken haskell packages Robert Vollmert
2019-07-25 11:45 ` [bug#36807] [PATCH] gnu: Remove ghc-regex-tdfa-rc (broken and unused) Robert Vollmert
2019-07-25 11:46 ` [bug#36807] [PATCH] gnu: Remove ghc-haddock-test " Robert Vollmert
2019-07-25 13:29 ` [bug#36807] remove obsolete broken haskell packages Timothy Sample
2019-08-01 16:23   ` [bug#36807] Please merge wip-haskell-updates (Re: [bug#36807] remove obsolete broken haskell packages) Robert Vollmert
     [not found]     ` <87mugmq5ll.fsf@ngyro.com>
     [not found]       ` <3C8EAC60-7073-4528-BC5D-548A018F08D8@vllmrt.net>
     [not found]         ` <878ss4pbkg.fsf@ngyro.com>
2019-08-08  4:28           ` bug#36807: " Timothy Sample

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).