From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:49618) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqdpo-0004wH-6L for guix-patches@gnu.org; Thu, 25 Jul 2019 09:31:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqdpm-0006OQ-Ow for guix-patches@gnu.org; Thu, 25 Jul 2019 09:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58004) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hqdpm-0006O4-As for guix-patches@gnu.org; Thu, 25 Jul 2019 09:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hqdpm-0004Du-6s for guix-patches@gnu.org; Thu, 25 Jul 2019 09:31:02 -0400 Subject: [bug#36807] remove obsolete broken haskell packages Resent-Message-ID: From: Timothy Sample References: Date: Thu, 25 Jul 2019 09:29:56 -0400 In-Reply-To: (Robert Vollmert's message of "Thu, 25 Jul 2019 13:40:58 +0200") Message-ID: <87muh2ckdn.fsf@ngyro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Robert Vollmert Cc: 36807@debbugs.gnu.org Hi Robert, Robert Vollmert writes: > This series removes some outdated packages that don=E2=80=99t build and > aren=E2=80=99t depend on. I remember that we intended to remove these last year. Indeed, Ricardo mentioned it when we were finishing up the upgrade to GHC 8.4: https://lists.gnu.org/archive/html/guix-devel/2018-09/msg00330.html Based on that, we could also get rid of =E2=80=9Cghc-packedstring=E2=80=9D = if it doesn=E2=80=99t have any dependants. Now for my usual commit message nit-picking. :) You should drop the parenthetical =E2=80=9Cbroken and unused=E2=80=9D note and add a period to = the end of the first line, like this: gnu: Remove ghc-regex-tdfa-rc. One of the commits says =E2=80=9CIt...=E2=80=9D and the other says =E2=80= =9CThis package...=E2=80=9D. They might as well be the same. Lastly, it=E2=80=99s usually =E2=80=9Cremo= ve variable=E2=80=9D instead of =E2=80=9Cremove package=E2=80=9D. Other than that, LGTM. Thanks! (Do you have commit access now or should I push these?) -- Tim