unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 40767@debbugs.gnu.org
Subject: [bug#40767] [PATCH] gnu: Add maradns.
Date: Sun, 26 Apr 2020 11:05:37 +0200	[thread overview]
Message-ID: <87mu6yfwgu.fsf@gmail.com> (raw)
In-Reply-To: <cu7tv17v3wy.fsf@systemreboot.net> (Arun Isaac's message of "Sat, 25 Apr 2020 23:33:25 +0530")


> guix lint checks for lines longer than 90 characters. Perhaps that's the
> new policy? See the function report-long-line in guix/lint.scm. It even
> has a comment noting that we don't warn at 80 characters.

Yes it's to avoid false positives with hashes and URLs. On the other
hand, in .dir-locals.el, fill-column variable is set to 78. Maybe we
would need to be more explicit in the "Coding style" section of the
manual.

> -           (lambda _
> +           (lambda* (#:key native-inputs #:allow-other-keys)
> +             ;; make_32bit_tables generates a header file that is used during
> +             ;; compilation. Hence, during cross compilation, it should be
> +             ;; built for the host system.
> +             (when ,(%current-target-system)
> +               (substitute* "rng/Makefile"
> +                 (("\\$\\(CC\\) -o make_32bit_tables")
> +                  (string-append (assoc-ref native-inputs "gcc")
> +                                 "/bin/gcc -o make_32bit_tables"))))

Nitpicking, you can use the target argument instead of
%current-target-system, this way:

--8<---------------cut here---------------start------------->8---
(lambda* (#:key native-inputs target #:allow-other-keys)
         ;; make_32bit_tables generates a header file that is used during
         ;; compilation. Hence, during cross compilation, it should be
         ;; built for the host system.
         (when target
           (substitute* "rng/Makefile"
                        (("\\$\\(CC\\) -o make_32bit_tables")
                         (string-append (assoc-ref native-inputs "gcc")
                                        "/bin/gcc -o make_32bit_tables")))))
--8<---------------cut here---------------end--------------->8---

Feel free to go ahead with this one,

Thanks,

Mathieu

  reply	other threads:[~2020-04-26  9:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 13:29 [bug#40767] [PATCH] gnu: Add maradns Arun Isaac
2020-04-22 13:49 ` Mathieu Othacehe
2020-04-22 15:09   ` Efraim Flashner
2020-04-22 17:26     ` Mathieu Othacehe
2020-04-22 19:01   ` Arun Isaac
2020-04-23  8:37     ` Mathieu Othacehe
2020-04-24 22:13       ` Arun Isaac
2020-04-25  8:13         ` Mathieu Othacehe
2020-04-25 10:58           ` Arun Isaac
2020-04-25 12:43             ` Mathieu Othacehe
2020-04-25 18:03               ` Arun Isaac
2020-04-26  9:05                 ` Mathieu Othacehe [this message]
2020-04-26  9:51                   ` Arun Isaac
2020-04-24 22:15       ` bug#40767: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu6yfwgu.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=40767@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).