unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 40767@debbugs.gnu.org
Subject: [bug#40767] [PATCH] gnu: Add maradns.
Date: Sat, 25 Apr 2020 14:43:06 +0200	[thread overview]
Message-ID: <87v9lng2hx.fsf@gmail.com> (raw)
In-Reply-To: <cu7zhazvnko.fsf@systemreboot.net> (Arun Isaac's message of "Sat, 25 Apr 2020 16:28:47 +0530")


> Yes, I checked before pushing. guix lint reported no warnings.

Then we may have to fix guix lint because it seems to me that this
snippet is above limit:

--8<---------------cut here---------------start------------->8---
    (string-append (assoc-ref %build-inputs "cross-gcc")
                "/bin/" ,(%current-target-system) "-gcc")
--8<---------------cut here---------------end--------------->8---


Nice fix, thank you :)

>                                 "/share/man/man8"))
>                 #t))))))
> +    (native-inputs
> +     `(,@(if (%current-target-system)
> +             `(("gcc" ,gcc))
> +             '())))

You don't need this bit, the native gcc is also present when
cross-compiling. Otherwise, LGTM!

Mathieu

  reply	other threads:[~2020-04-25 12:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 13:29 [bug#40767] [PATCH] gnu: Add maradns Arun Isaac
2020-04-22 13:49 ` Mathieu Othacehe
2020-04-22 15:09   ` Efraim Flashner
2020-04-22 17:26     ` Mathieu Othacehe
2020-04-22 19:01   ` Arun Isaac
2020-04-23  8:37     ` Mathieu Othacehe
2020-04-24 22:13       ` Arun Isaac
2020-04-25  8:13         ` Mathieu Othacehe
2020-04-25 10:58           ` Arun Isaac
2020-04-25 12:43             ` Mathieu Othacehe [this message]
2020-04-25 18:03               ` Arun Isaac
2020-04-26  9:05                 ` Mathieu Othacehe
2020-04-26  9:51                   ` Arun Isaac
2020-04-24 22:15       ` bug#40767: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9lng2hx.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=40767@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).