From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:38504) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSdEg-0004Ma-R6 for guix-patches@gnu.org; Sun, 26 Apr 2020 05:06:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSdEg-0000jz-BK for guix-patches@gnu.org; Sun, 26 Apr 2020 05:06:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSdEf-0000jr-Uw for guix-patches@gnu.org; Sun, 26 Apr 2020 05:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSdEf-0002V7-Oi for guix-patches@gnu.org; Sun, 26 Apr 2020 05:06:01 -0400 Subject: [bug#40767] [PATCH] gnu: Add maradns. Resent-Message-ID: From: Mathieu Othacehe References: <20200422132922.9539-1-arunisaac@systemreboot.net> <87lfmnock3.fsf@gmail.com> <87blnioawj.fsf@gmail.com> <87y2qkx9sh.fsf@gmail.com> <87v9lng2hx.fsf@gmail.com> Date: Sun, 26 Apr 2020 11:05:37 +0200 In-Reply-To: (Arun Isaac's message of "Sat, 25 Apr 2020 23:33:25 +0530") Message-ID: <87mu6yfwgu.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 40767@debbugs.gnu.org > guix lint checks for lines longer than 90 characters. Perhaps that's the > new policy? See the function report-long-line in guix/lint.scm. It even > has a comment noting that we don't warn at 80 characters. Yes it's to avoid false positives with hashes and URLs. On the other hand, in .dir-locals.el, fill-column variable is set to 78. Maybe we would need to be more explicit in the "Coding style" section of the manual. > - (lambda _ > + (lambda* (#:key native-inputs #:allow-other-keys) > + ;; make_32bit_tables generates a header file that is used during > + ;; compilation. Hence, during cross compilation, it should be > + ;; built for the host system. > + (when ,(%current-target-system) > + (substitute* "rng/Makefile" > + (("\\$\\(CC\\) -o make_32bit_tables") > + (string-append (assoc-ref native-inputs "gcc") > + "/bin/gcc -o make_32bit_tables")))) Nitpicking, you can use the target argument instead of %current-target-system, this way: --8<---------------cut here---------------start------------->8--- (lambda* (#:key native-inputs target #:allow-other-keys) ;; make_32bit_tables generates a header file that is used during ;; compilation. Hence, during cross compilation, it should be ;; built for the host system. (when target (substitute* "rng/Makefile" (("\\$\\(CC\\) -o make_32bit_tables") (string-append (assoc-ref native-inputs "gcc") "/bin/gcc -o make_32bit_tables"))))) --8<---------------cut here---------------end--------------->8--- Feel free to go ahead with this one, Thanks, Mathieu