* [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag.
@ 2020-09-08 10:48 Michael Rohleder
2020-09-09 7:38 ` bug#43273: " Ludovic Courtès
2020-09-09 8:28 ` [bug#43273] " Ludovic Courtès
0 siblings, 2 replies; 3+ messages in thread
From: Michael Rohleder @ 2020-09-08 10:48 UTC (permalink / raw)
To: 43273; +Cc: Michael Rohleder
* gnu/packages/mp3.scm (taglib): Add "" around the substitution of
ZLIB_LIBRARIES_FLAGS.
---
gnu/packages/mp3.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index a7574f0cf9..2e9b023407 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -182,9 +182,9 @@ a highly stable and efficient implementation.")
;; flag for zlib.
(substitute* "CMakeLists.txt"
(("set\\(ZLIB_LIBRARIES_FLAGS -lz\\)")
- (string-append "set(ZLIB_LIBRARIES_FLAGS -L"
+ (string-append "set(ZLIB_LIBRARIES_FLAGS \"-L"
(assoc-ref inputs "zlib")
- " -lz)")))
+ " -lz\")")))
#t)))))
(inputs `(("zlib" ,zlib)))
(home-page "https://taglib.org")
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* bug#43273: [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag.
2020-09-08 10:48 [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag Michael Rohleder
@ 2020-09-09 7:38 ` Ludovic Courtès
2020-09-09 8:28 ` [bug#43273] " Ludovic Courtès
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2020-09-09 7:38 UTC (permalink / raw)
To: Michael Rohleder; +Cc: 43273-done
Hi,
Michael Rohleder <mike@rohleder.de> skribis:
> * gnu/packages/mp3.scm (taglib): Add "" around the substitution of
> ZLIB_LIBRARIES_FLAGS.
Applied. Thanks and sorry for the delay!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag.
2020-09-08 10:48 [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag Michael Rohleder
2020-09-09 7:38 ` bug#43273: " Ludovic Courtès
@ 2020-09-09 8:28 ` Ludovic Courtès
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2020-09-09 8:28 UTC (permalink / raw)
To: Michael Rohleder; +Cc: 43273
Michael Rohleder <mike@rohleder.de> skribis:
> * gnu/packages/mp3.scm (taglib): Add "" around the substitution of
> ZLIB_LIBRARIES_FLAGS.
> ---
> gnu/packages/mp3.scm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index a7574f0cf9..2e9b023407 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -182,9 +182,9 @@ a highly stable and efficient implementation.")
> ;; flag for zlib.
> (substitute* "CMakeLists.txt"
> (("set\\(ZLIB_LIBRARIES_FLAGS -lz\\)")
> - (string-append "set(ZLIB_LIBRARIES_FLAGS -L"
> + (string-append "set(ZLIB_LIBRARIES_FLAGS \"-L"
> (assoc-ref inputs "zlib")
> - " -lz)")))
> + " -lz\")")))
As it turns out, we were also missing “/lib” there… I’ve added it, and
hopefully now we’re all fine!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 10:48 [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag Michael Rohleder
2020-09-09 7:38 ` bug#43273: " Ludovic Courtès
2020-09-09 8:28 ` [bug#43273] " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).