From: "Ludovic Courtès" <ludo@gnu.org>
To: Michael Rohleder <mike@rohleder.de>
Cc: 43273@debbugs.gnu.org
Subject: [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag.
Date: Wed, 09 Sep 2020 10:28:59 +0200 [thread overview]
Message-ID: <87eenbmjzo.fsf@gnu.org> (raw)
In-Reply-To: <20200908104835.12211-1-mike@rohleder.de> (Michael Rohleder's message of "Tue, 8 Sep 2020 12:48:35 +0200")
Michael Rohleder <mike@rohleder.de> skribis:
> * gnu/packages/mp3.scm (taglib): Add "" around the substitution of
> ZLIB_LIBRARIES_FLAGS.
> ---
> gnu/packages/mp3.scm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index a7574f0cf9..2e9b023407 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -182,9 +182,9 @@ a highly stable and efficient implementation.")
> ;; flag for zlib.
> (substitute* "CMakeLists.txt"
> (("set\\(ZLIB_LIBRARIES_FLAGS -lz\\)")
> - (string-append "set(ZLIB_LIBRARIES_FLAGS -L"
> + (string-append "set(ZLIB_LIBRARIES_FLAGS \"-L"
> (assoc-ref inputs "zlib")
> - " -lz)")))
> + " -lz\")")))
As it turns out, we were also missing “/lib” there… I’ve added it, and
hopefully now we’re all fine!
Ludo’.
prev parent reply other threads:[~2020-09-09 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 10:48 [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag Michael Rohleder
2020-09-09 7:38 ` bug#43273: " Ludovic Courtès
2020-09-09 8:28 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eenbmjzo.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43273@debbugs.gnu.org \
--cc=mike@rohleder.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).