* [bug#43604] [PATCH] services: %desktop-services: Setuid root NTFS and NFS mount helpers.
@ 2020-09-25 1:36 Maxim Cournoyer
2020-09-29 20:47 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Maxim Cournoyer @ 2020-09-25 1:36 UTC (permalink / raw)
To: 43604; +Cc: Maxim Cournoyer
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=yes, Size: 2073 bytes --]
Combined with commit def6e2ae46, this allows unprivileged users to mount file
systems marked with the "user" option. It adds less than 4 MiB to the closure
of the lightweight-desktop.tmpl operating system template.
* gnu/services/desktop.scm (%desktop-services): Extend the
setuid-program-service-type service with the 'mount.nfs' and 'mount.nfs-3g'
programs.
---
gnu/services/desktop.scm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 1dcf71d359..f9f666e791 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -3,7 +3,7 @@
;;; Copyright © 2015 Andy Wingo <wingo@igalia.com>
;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2016 Sou Bunnbu <iyzsong@gmail.com>
-;;; Copyright © 2017 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2017, 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
;;; Copyright © 2017 Nikita <nikita@n0.is>
;;; Copyright © 2018, 2020 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2018 Ricardo Wurmus <rekado@elephly.net>
@@ -54,6 +54,7 @@
#:use-module (gnu packages linux)
#:use-module (gnu packages libusb)
#:use-module (gnu packages mate)
+ #:use-module (gnu packages nfs)
#:use-module (gnu packages enlightenment)
#:use-module (guix deprecation)
#:use-module (guix records)
@@ -1203,6 +1204,12 @@ or setting its password with passwd.")))
;; perform administrative tasks (similar to "sudo").
polkit-wheel-service
+ ;; Allow desktop users to also mount NTFS and NFS file systems
+ ;; without root.
+ (simple-service 'mount-setuid-helpers setuid-program-service-type
+ (list (file-append nfs-utils "/sbin/mount.nfs")
+ (file-append ntfs-3g "/sbin/mount.ntfs-3g")))
+
;; The global fontconfig cache directory can sometimes contain
;; stale entries, possibly referencing fonts that have been GC'd,
;; so mount it read-only.
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#43604] [PATCH] services: %desktop-services: Setuid root NTFS and NFS mount helpers.
2020-09-25 1:36 [bug#43604] [PATCH] services: %desktop-services: Setuid root NTFS and NFS mount helpers Maxim Cournoyer
@ 2020-09-29 20:47 ` Ludovic Courtès
2020-10-01 19:50 ` bug#43604: " Maxim Cournoyer
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2020-09-29 20:47 UTC (permalink / raw)
To: Maxim Cournoyer; +Cc: 43604
Hi Maxim,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Combined with commit def6e2ae46, this allows unprivileged users to mount file
> systems marked with the "user" option. It adds less than 4 MiB to the closure
> of the lightweight-desktop.tmpl operating system template.
>
> * gnu/services/desktop.scm (%desktop-services): Extend the
> setuid-program-service-type service with the 'mount.nfs' and 'mount.nfs-3g'
> programs.
Looks reasonable to me.
Thank you!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#43604: [PATCH] services: %desktop-services: Setuid root NTFS and NFS mount helpers.
2020-09-29 20:47 ` Ludovic Courtès
@ 2020-10-01 19:50 ` Maxim Cournoyer
0 siblings, 0 replies; 3+ messages in thread
From: Maxim Cournoyer @ 2020-10-01 19:50 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 43604-done
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Combined with commit def6e2ae46, this allows unprivileged users to mount file
>> systems marked with the "user" option. It adds less than 4 MiB to the closure
>> of the lightweight-desktop.tmpl operating system template.
>>
>> * gnu/services/desktop.scm (%desktop-services): Extend the
>> setuid-program-service-type service with the 'mount.nfs' and 'mount.nfs-3g'
>> programs.
>
> Looks reasonable to me.
>
> Thank you!
Thanks for the review! Pushed as commit d40c9f6c85.
Maxim
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-01 19:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-25 1:36 [bug#43604] [PATCH] services: %desktop-services: Setuid root NTFS and NFS mount helpers Maxim Cournoyer
2020-09-29 20:47 ` Ludovic Courtès
2020-10-01 19:50 ` bug#43604: " Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).