From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2JGtLulJbV9lWQAA0tVLHw (envelope-from ) for ; Fri, 25 Sep 2020 01:37:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CHFhKulJbV/PJQAAB5/wlQ (envelope-from ) for ; Fri, 25 Sep 2020 01:37:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 43952940547 for ; Fri, 25 Sep 2020 01:37:45 +0000 (UTC) Received: from localhost ([::1]:39912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLcgC-00009L-1k for larch@yhetil.org; Thu, 24 Sep 2020 21:37:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLcfW-00089J-LW for guix-patches@gnu.org; Thu, 24 Sep 2020 21:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLcfW-0008HS-Bp for guix-patches@gnu.org; Thu, 24 Sep 2020 21:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLcfW-0003fP-7v for guix-patches@gnu.org; Thu, 24 Sep 2020 21:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43604] [PATCH] services: %desktop-services: Setuid root NTFS and NFS mount helpers. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 25 Sep 2020 01:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43604 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43604@debbugs.gnu.org Cc: Maxim Cournoyer X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160099778314041 (code B ref -1); Fri, 25 Sep 2020 01:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Sep 2020 01:36:23 +0000 Received: from localhost ([127.0.0.1]:42135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLceo-0003eK-RW for submit@debbugs.gnu.org; Thu, 24 Sep 2020 21:36:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:60746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLcel-0003eA-E9 for submit@debbugs.gnu.org; Thu, 24 Sep 2020 21:36:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLcel-0007hK-7j for guix-patches@gnu.org; Thu, 24 Sep 2020 21:36:15 -0400 Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]:41642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLcej-0008DL-Cl for guix-patches@gnu.org; Thu, 24 Sep 2020 21:36:14 -0400 Received: by mail-qv1-xf43.google.com with SMTP id ef16so554607qvb.8 for ; Thu, 24 Sep 2020 18:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a29JA4zVnHQ0fkXOC8AaFxNvTFAQQDDzrDnyvZSp8iE=; b=ayfjH0b+z8X+Cs4HSIbVi8UZbwdWLEMKXiuA8/PAsh/hVwsa+eY3Qz35pct1gncHdz SKjAd1zFKE/ckBnFAXmKt8G9o/6VKknxEX0zrZphlpVkFZrvygvgO/kWnCRtc8eSjzhE WrY+eOLeY6cJcxNGphN5qu4jDN47QOLIwGVMFfweOeRQ3+F2uGIpJ4Tz8U1DbaleW1et MdFWwUYD2kbHOWdjg3NlXjK1/ygJNW3e9y987j3gN/yFJ72pVjXNcr9AjdV/UOLPJpA7 rAjTW9XW5PoEFitnsaM+HWAE+I3ksXr8I0I0IULkHtmIHGORE6TzHYMfD3cyZ2eVM1vW 63CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a29JA4zVnHQ0fkXOC8AaFxNvTFAQQDDzrDnyvZSp8iE=; b=cUhDML6uvADc5wvW80VxByXQp9MUnbczrBaVUeeKdNcLYNDyQCsw5X0shzl+RsIIzH z19zr43bGvWClT2XkfD6U4h2/uHmYl9kG+GxqUGrOCXvyrmb3FdPcPkFgszkM2QGuf+1 r7Q5FaH1vKC00KoAEIzjXCVq6AMSVJzsxvp5B+/Xdr0nbbvqlzBfujib4IrRCbL4AVcl nNJQIWLNv9RYYak3bL2qCd46ZujJoUy98bXLPzlFwpd6Ke4TCLQ4mpQP+ED3xte+IdOQ 9PaTgrCKoAlTf4kMnQssHWW0MLcfLDr90WlkoQ3zZdVxKt8DUiMgle8IIHSPP+JLDq+J Eczg== X-Gm-Message-State: AOAM5306nk95jvNHqsdq9vTsimJeglCacPl5JNNN1vBBg5DdEmgJOXz5 7HKFM5z2p6nNpRiKhr9JXpZycL3Q1Ns21Q== X-Google-Smtp-Source: ABdhPJxGv7UYEeievpWVoqVWX44ZEisVfONj8XWglkhg+kIPs/om1UkyDhq5AQ8h4rjtICIYp7m24g== X-Received: by 2002:ad4:4b61:: with SMTP id m1mr2274862qvx.11.1600997772000; Thu, 24 Sep 2020 18:36:12 -0700 (PDT) Received: from localhost.localdomain (dsl-10-130-151.b2b2c.ca. [72.10.130.151]) by smtp.gmail.com with ESMTPSA id y20sm823674qkj.70.2020.09.24.18.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 18:36:11 -0700 (PDT) From: Maxim Cournoyer Date: Thu, 24 Sep 2020 21:36:43 -0400 Message-Id: <20200925013643.23795-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=yes Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::f43; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf43.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.7 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.0 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=ayfjH0b+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: DybfQhEUa7bu Combined with commit def6e2ae46, this allows unprivileged users to mount file systems marked with the "user" option. It adds less than 4 MiB to the closure of the lightweight-desktop.tmpl operating system template. * gnu/services/desktop.scm (%desktop-services): Extend the setuid-program-service-type service with the 'mount.nfs' and 'mount.nfs-3g' programs. --- gnu/services/desktop.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm index 1dcf71d359..f9f666e791 100644 --- a/gnu/services/desktop.scm +++ b/gnu/services/desktop.scm @@ -3,7 +3,7 @@ ;;; Copyright © 2015 Andy Wingo ;;; Copyright © 2015 Mark H Weaver ;;; Copyright © 2016 Sou Bunnbu -;;; Copyright © 2017 Maxim Cournoyer +;;; Copyright © 2017, 2020 Maxim Cournoyer ;;; Copyright © 2017 Nikita ;;; Copyright © 2018, 2020 Efraim Flashner ;;; Copyright © 2018 Ricardo Wurmus @@ -54,6 +54,7 @@ #:use-module (gnu packages linux) #:use-module (gnu packages libusb) #:use-module (gnu packages mate) + #:use-module (gnu packages nfs) #:use-module (gnu packages enlightenment) #:use-module (guix deprecation) #:use-module (guix records) @@ -1203,6 +1204,12 @@ or setting its password with passwd."))) ;; perform administrative tasks (similar to "sudo"). polkit-wheel-service + ;; Allow desktop users to also mount NTFS and NFS file systems + ;; without root. + (simple-service 'mount-setuid-helpers setuid-program-service-type + (list (file-append nfs-utils "/sbin/mount.nfs") + (file-append ntfs-3g "/sbin/mount.ntfs-3g"))) + ;; The global fontconfig cache directory can sometimes contain ;; stale entries, possibly referencing fonts that have been GC'd, ;; so mount it read-only. -- 2.28.0