From: "Ludovic Courtès" <ludo@gnu.org>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 48697@debbugs.gnu.org, raingloom <raingloom@riseup.net>
Subject: [bug#48697] [PATCH v3] import: Add CHICKEN egg importer.
Date: Tue, 01 Jun 2021 23:10:54 +0200 [thread overview]
Message-ID: <87mts9z3xd.fsf@gnu.org> (raw)
In-Reply-To: <9419cea6a6580c244a22d358c754032486f87b1c.1622485631.git.public@yoctocell.xyz> (Xinglu Chen's message of "Mon, 31 May 2021 20:29:12 +0200")
Hi!
Xinglu Chen <public@yoctocell.xyz> skribis:
> * guix/import/egg.scm: New file.
> * guix/scripts/import/egg.scm: New file.
> * tests/egg.scm: New file.
> * Makefile.am (MODULES, SCM_TESTS): Register them.
> * po/guix/POTFILES.in: Likewise.
> * guix/scripts/import.scm (importers): Add egg importer.
> * doc/guix.texi (Invoking guix import, Invoking guix refresh): Document it.
> ---
> Changes since v2:
> * Remove message telling the user that the egg doesn’t exist, ‘guix
> import’ will already throw an error if this happens.
>
> * Fixed the failing test, I just had to change (license (list 'a 'b)) to
> (license '(a b)), duh.
This LGTM, except this last bit, as shown here:
> +(define-package-matcher match-chicken-foo
> + ('package
> + ('name "chicken-foo")
> + ('version "1.0.0")
> + ('source (? file-like? source))
> + ('build-system 'chicken-build-system)
> + ('arguments ('quasiquote ('#:egg-name "foo")))
> + ('native-inputs
> + ('quasiquote
> + (("chicken-test" ('unquote chicken-test))
> + ("chicken-srfi-1" ('unquote chicken-srfi-1))
> + ("chicken-begin-syntax" ('unquote chicken-begin-syntax)))))
> + ('inputs
> + ('quasiquote
> + (("libgit2" ('unquote libgit2)))))
> + ('propagated-inputs
> + ('quasiquote
> + (("chicken-datatype" ('unquote chicken-datatype)))))
> + ('home-page "https://wiki.call-cc.org/egg/foo")
> + ('synopsis "Example egg")
> + ('description #f)
> + ('license '(license:gpl3 license:expat))))
The generated ‘license’ team is incorrect. For multiple licenses, the
generated code should look like:
(package
;; …
(license (list license:gpl3 license:expat)))
For a single license:
(package
;; …
(license license:gpl3+))
Compare with:
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix import egg sourcehut | tail -1
Starting download of /tmp/guix-file.N300R0
From https://code.call-cc.org/egg-tarballs/5/sourcehut/sourcehut-0.3.3.tar.gz...
….3.3.tar.gz 20KiB 678KiB/s 00:00 [##################] 100.0%
(license (license:bsd?)))
--8<---------------cut here---------------end--------------->8---
That’s the last remaining issue in my view. Could you send a v3?
BTW, if you want, you can also send a snippet for ‘etc/news.scm’ to
announce ‘guix import egg’ to fellow users! You can take inspiration
from the ‘guix import go’ news entry; I’ll fix up the commit ID when
committing.
Thanks!
Ludo’.
next prev parent reply other threads:[~2021-06-01 21:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 12:48 [bug#48697] [PATCH] import: Add CHICKEN egg importer Xinglu Chen
2021-05-27 19:21 ` raingloom
2021-05-29 16:44 ` Ludovic Courtès
2021-05-29 19:51 ` Xinglu Chen
2021-05-31 16:15 ` Ludovic Courtès
2021-05-31 18:00 ` Xinglu Chen
2021-05-31 18:29 ` [bug#48697] [PATCH v3] " Xinglu Chen
2021-06-01 21:10 ` Ludovic Courtès [this message]
2021-06-01 22:05 ` Xinglu Chen
2021-06-02 15:18 ` [bug#48697] [PATCH v4] " Xinglu Chen
2021-06-03 11:09 ` bug#48697: " Ludovic Courtès
2021-06-03 13:58 ` [bug#48697] " Xinglu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mts9z3xd.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=48697@debbugs.gnu.org \
--cc=public@yoctocell.xyz \
--cc=raingloom@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).