unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 48697@debbugs.gnu.org, raingloom <raingloom@riseup.net>
Subject: [bug#48697] [PATCH] import: Add CHICKEN egg importer.
Date: Mon, 31 May 2021 18:15:36 +0200	[thread overview]
Message-ID: <87v96y3mmv.fsf@gnu.org> (raw)
In-Reply-To: <87eedppbdh.fsf@yoctocell.xyz> (Xinglu Chen's message of "Sat, 29 May 2021 21:51:06 +0200")

Heya,

Xinglu Chen <public@yoctocell.xyz> skribis:

> On Sat, May 29 2021, Ludovic Courtès wrote:

[...]

>>> +(define (find-latest-version name)
>>> +  "Get the latest version of the egg NAME."
>>> +  (let ((directory (scandir (egg-directory name))))
>>> +    (if directory
>>> +        (last directory)
>>> +        (begin
>>> +          (format #t (G_ "Package not found in eggs repository: ~a~%") name)
>>> +          #f))))
>>
>> This should be rendered with ‘warning’ from (guix diagnostics).
>>
>> Or maybe it should be raised as a ‘formatted-message’ exception?
>
> Not sure if it should be an exception or not, if you run ‘guix import egg’
> on a package that doesn’t exist, it will already throw an error
>
> $ ./pre-inst-env guix import egg lasdkfj
> Package not found in eggs repository: lasdkfj
> guix import: error: failed to download meta-data for package 'lasdkfj'

True!  So perhaps we can omit the extra message altogether since it
doesn’t convey any more info.

Thanks,
Ludo’.




  reply	other threads:[~2021-05-31 16:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 12:48 [bug#48697] [PATCH] import: Add CHICKEN egg importer Xinglu Chen
2021-05-27 19:21 ` raingloom
2021-05-29 16:44 ` Ludovic Courtès
2021-05-29 19:51   ` Xinglu Chen
2021-05-31 16:15     ` Ludovic Courtès [this message]
2021-05-31 18:00       ` Xinglu Chen
2021-05-31 18:29 ` [bug#48697] [PATCH v3] " Xinglu Chen
2021-06-01 21:10   ` Ludovic Courtès
2021-06-01 22:05     ` Xinglu Chen
2021-06-02 15:18   ` [bug#48697] [PATCH v4] " Xinglu Chen
2021-06-03 11:09     ` bug#48697: " Ludovic Courtès
2021-06-03 13:58       ` [bug#48697] " Xinglu Chen
     [not found] <id:df2632846c36a40d0effae2c9d7036281c48868f.1622118826.git.public@yoctocell.xyz>
2021-05-29 21:41 ` [bug#48697] [PATCH] " Xinglu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v96y3mmv.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=48697@debbugs.gnu.org \
    --cc=public@yoctocell.xyz \
    --cc=raingloom@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).