From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8O/GNaeitmADGgEAgWs5BA (envelope-from ) for ; Tue, 01 Jun 2021 23:12:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 0Jr6MKeitmATcQAA1q6Kng (envelope-from ) for ; Tue, 01 Jun 2021 21:12:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 26D2E22B2E for ; Tue, 1 Jun 2021 23:12:07 +0200 (CEST) Received: from localhost ([::1]:41024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loBgE-0004uI-4l for larch@yhetil.org; Tue, 01 Jun 2021 17:12:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loBgA-0004tr-7b for guix-patches@gnu.org; Tue, 01 Jun 2021 17:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loBgA-0006T3-0S for guix-patches@gnu.org; Tue, 01 Jun 2021 17:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loBg9-00022P-Rq for guix-patches@gnu.org; Tue, 01 Jun 2021 17:12:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48697] [PATCH v3] import: Add CHICKEN egg importer. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Jun 2021 21:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48697 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 48697@debbugs.gnu.org, raingloom Received: via spool by 48697-submit@debbugs.gnu.org id=B48697.16225818667767 (code B ref 48697); Tue, 01 Jun 2021 21:12:01 +0000 Received: (at 48697) by debbugs.gnu.org; 1 Jun 2021 21:11:06 +0000 Received: from localhost ([127.0.0.1]:38041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loBfG-00021C-6P for submit@debbugs.gnu.org; Tue, 01 Jun 2021 17:11:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loBfE-00020i-2h for 48697@debbugs.gnu.org; Tue, 01 Jun 2021 17:11:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47320) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loBf7-0005mf-VI; Tue, 01 Jun 2021 17:10:57 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57836 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loBf6-0003ML-Mw; Tue, 01 Jun 2021 17:10:57 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <9419cea6a6580c244a22d358c754032486f87b1c.1622485631.git.public@yoctocell.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Prairial an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 01 Jun 2021 23:10:54 +0200 In-Reply-To: <9419cea6a6580c244a22d358c754032486f87b1c.1622485631.git.public@yoctocell.xyz> (Xinglu Chen's message of "Mon, 31 May 2021 20:29:12 +0200") Message-ID: <87mts9z3xd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622581927; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=rrFYkHPiQD203un/IaectJLAML7VzOuuWcfDaMyWUR0=; b=bYx+OSkEhkHIf8X7pAmE9G1CoeLDV4CUK/uDypdi39Le/cdjcrG8/RAmQAxd7nKnfgZws5 JnE62B1ydgtzGbkKCFIwU3SwIbN6uiJhlc4WD2O+xJPGP1tbqzErayVKhSmVWsh9q53JbN 5Lkllt8yfsjxQxlnxxBvVNcJEyiimJ6MXJEG7PU4p5gSRDTtfTMoFjmLY2CQkW302vAKOC 6elj7Sx6ufU1SWG02z277Ox4jURsRjg15J66z+LaZz/LWjO6TI5kFi7Gvnp1IAnRq4Ugcq G2CN0Uv/PUoVuRz4uEhS3MXjrgMRsKo6fpxYK/7d5FrQ1HmGG/l1QUIdJ//hqQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622581927; a=rsa-sha256; cv=none; b=J/tYnvHML6V66q9R2IF5d8aQv5iXNa63SzYaoIgwK5dcbtWztlD74SOhlTEsGg16vcP2RQ ibr/6i+1mj0rmrH1yuIsdqaONxaMyrgovvAOPr8UNgyrLgmW0rJfXKv6i3DDULS0wWwOIj DpjtAvKyUO1hCnQnwa9/0SAiNIghZjwJsuVaKpuMeY0A0kw+9GyU33YUjW13VdsWU1PPHY gaewEt9KDjwkGzuC+heHSb2NLRsYEfrePyIIRHd4CvlRX1Ae7flKALeYN+7Gk1Xp2Ax/dE zr6LbAYXygrML+sn25lKJt65ExN8mJNmygLsYTD18cutpX9uVa7hRNUe0MUCyA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 26D2E22B2E X-Spam-Score: -2.93 X-Migadu-Scanner: scn1.migadu.com X-TUID: x97wPmcCR4bP Hi! Xinglu Chen skribis: > * guix/import/egg.scm: New file. > * guix/scripts/import/egg.scm: New file. > * tests/egg.scm: New file. > * Makefile.am (MODULES, SCM_TESTS): Register them. > * po/guix/POTFILES.in: Likewise. > * guix/scripts/import.scm (importers): Add egg importer. > * doc/guix.texi (Invoking guix import, Invoking guix refresh): Document i= t. > --- > Changes since v2: > * Remove message telling the user that the egg doesn=E2=80=99t exist, =E2= =80=98guix > import=E2=80=99 will already throw an error if this happens. > > * Fixed the failing test, I just had to change (license (list 'a 'b)) to > (license '(a b)), duh. This LGTM, except this last bit, as shown here: > +(define-package-matcher match-chicken-foo > + ('package > + ('name "chicken-foo") > + ('version "1.0.0") > + ('source (? file-like? source)) > + ('build-system 'chicken-build-system) > + ('arguments ('quasiquote ('#:egg-name "foo"))) > + ('native-inputs > + ('quasiquote > + (("chicken-test" ('unquote chicken-test)) > + ("chicken-srfi-1" ('unquote chicken-srfi-1)) > + ("chicken-begin-syntax" ('unquote chicken-begin-syntax))))) > + ('inputs > + ('quasiquote > + (("libgit2" ('unquote libgit2))))) > + ('propagated-inputs > + ('quasiquote > + (("chicken-datatype" ('unquote chicken-datatype))))) > + ('home-page "https://wiki.call-cc.org/egg/foo") > + ('synopsis "Example egg") > + ('description #f) > + ('license '(license:gpl3 license:expat)))) The generated =E2=80=98license=E2=80=99 team is incorrect. For multiple li= censes, the generated code should look like: (package ;; =E2=80=A6 (license (list license:gpl3 license:expat))) For a single license: (package ;; =E2=80=A6 (license license:gpl3+)) Compare with: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix import egg sourcehut | tail -1 Starting download of /tmp/guix-file.N300R0 >From https://code.call-cc.org/egg-tarballs/5/sourcehut/sourcehut-0.3.3.tar.= gz... =E2=80=A6.3.3.tar.gz 20KiB 678KiB/s 00:00 [#############= #####] 100.0% (license (license:bsd?))) --8<---------------cut here---------------end--------------->8--- That=E2=80=99s the last remaining issue in my view. Could you send a v3? BTW, if you want, you can also send a snippet for =E2=80=98etc/news.scm=E2= =80=99 to announce =E2=80=98guix import egg=E2=80=99 to fellow users! You can take i= nspiration from the =E2=80=98guix import go=E2=80=99 news entry; I=E2=80=99ll fix up t= he commit ID when committing. Thanks! Ludo=E2=80=99.