From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id AMvZLaG33WU4JwAAe85BDQ:P1 (envelope-from ) for ; Tue, 27 Feb 2024 11:21:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id AMvZLaG33WU4JwAAe85BDQ (envelope-from ) for ; Tue, 27 Feb 2024 11:21:21 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="h/0+CInc"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709029281; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XNskpXhaR9l+rdWtHaGu06D+LG2HRuirY8nWxICruXQ=; b=MlDA/gbx/IWDL7anBfK/zNQVfC750NMYaZwIPJHGaSGuzI7K92fQGsJIt4nq7P/YZe6b9V F9uFwn3BsOENOX6Xet923zYjsivm1VLpJOZKZivrDDKb2R4rVIa3mksceg6niv6TFk8n+S BJUwGSYQKQaLmtvdMMFpe95v/y5lvOexM4vn6hMNQQdSQIwV3DI0lfdF5A4NnnHPMruwbj XoGgaKliBbHvZB6bfFlu0LkWxptFPBOe6XYtf/0H6DYqU8KHCiKYcOHk5L6YoSpsh/2a/F C0i1ybMnqhLChbDsVG/OVwilRfGXwLujXyjAV9uVkUabZQ1UmOSkEl8xCN6sVA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="h/0+CInc"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709029281; a=rsa-sha256; cv=none; b=YtwAbPqjswkcqfwIBQWKEtkJSUDPvwqAkv8/fv8sLKhxjXWixt5vwyiFclb/n2CLkFRLGY 1naMQYKm68nqJxl96YpWRKqvwQHUBrEmsc/V2INNR7afmOKFoxg4sjIJUOQNpJGhzQUogw 7k0jCIS1OaSXWfo1vStTCHygtYRhxmCuRMnfh+miqz7tqF+0+CZBbZcgczRbXoXp6tWHlj 86XuWDx/T7ImyBGMQ8zUwCVqqoNDkIJpQOh0Zx+UIkmI4H1qvGV7I5L+WZGSI1160c9UYM 3LdVe29UYCI9xO11PdWajLjD1+ICt+6jhc0dP8Yln+ZwjwIhXu+ms/5nIxTczA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7F98942660 for ; Tue, 27 Feb 2024 11:21:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1reuZl-0008TY-Gc; Tue, 27 Feb 2024 05:20:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reuZh-0008Ld-Ju for guix-patches@gnu.org; Tue, 27 Feb 2024 05:20:38 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1reuZh-0003lt-Bf for guix-patches@gnu.org; Tue, 27 Feb 2024 05:20:37 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1reua5-0008HL-Vr; Tue, 27 Feb 2024 05:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67257] [PATCH v2 2/2] gnu: Add x2goclient. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org, steve@futurile.net Resent-Date: Tue, 27 Feb 2024 10:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67257 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Steve George Cc: nicolas.debonnaire@gmail.com, 67257@debbugs.gnu.org Received: via spool by 67257-submit@debbugs.gnu.org id=B67257.170902922431700 (code B ref 67257); Tue, 27 Feb 2024 10:21:01 +0000 Received: (at 67257) by debbugs.gnu.org; 27 Feb 2024 10:20:24 +0000 Received: from localhost ([127.0.0.1]:40875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reuZT-0008F2-PY for submit@debbugs.gnu.org; Tue, 27 Feb 2024 05:20:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reuZR-0008E3-Jf for 67257@debbugs.gnu.org; Tue, 27 Feb 2024 05:20:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reuIP-000724-T9; Tue, 27 Feb 2024 05:02:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=XNskpXhaR9l+rdWtHaGu06D+LG2HRuirY8nWxICruXQ=; b=h/0+CIncxk1jZNTF8SZK beJp2Si+Lgr07W3kFSJbUx5TVfDbCjJalLOrMMpgXM3FypKdePHkQJGDCwtyKEa5UkSKK0UJq1GRk fGn0SdShD8C+2Ytrkl3KnHge/4cguAJuaKO6gfSffk99wuCMsNI9/l+sNVfK6Av+zELx14v2T61ag TkyOqkl3FTfPuIqCozhNIKN7P4W0QzYxybc81IixHyJjj4Hb/ubqbcPJJiS/duYZGTW/Tw0HR59Xj wZbxrZ4Sh0fntXWL9fJtEvZVIIptLXzqIthbhiTn/e0SJK/vi7rEybI/kIPeoJ2i5G4SmAGe7w7bk ytyGqtV0WelMRg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <89c8896f76e5c5e3f68dfd7f36cac23ad3a79330.1708638616.git.steve@futurile.net> (Steve George's message of "Thu, 22 Feb 2024 22:08:20 +0000") References: <89c8896f76e5c5e3f68dfd7f36cac23ad3a79330.1708638616.git.steve@futurile.net> Date: Tue, 27 Feb 2024 11:02:41 +0100 Message-ID: <87msrmi5ry.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -7.17 X-Spam-Score: -7.17 X-Migadu-Queue-Id: 7F98942660 X-Migadu-Scanner: mx11.migadu.com X-TUID: DkbX+vJ0vz/R Steve George skribis: > From: nicodebo > > * gnu/packages/nx.scm (x2goclient): New variable. > > Reviewed-by: Steve George > > Change-Id: Ib0ff6328ede3fb4a0b48462ac1a003438c53c862 [...] > + (substitute* "src/onmainwindow.cpp" > + (("/usr/sbin/sshd") > + (which "sshd")))))) Rather use =E2=80=98search-input-file=E2=80=99 here, as mentioned in my oth= er message. > + (native-inputs (list pkg-config > + qttools-5 > + qtbase-5 > + qtx11extras > + qtsvg-5 > + libssh > + cups > + libxpm > + openldap > + gcc-toolchain)) You can omit =E2=80=98gcc-toolchain=E2=80=99. Most likely, everything but = =E2=80=98pkg-config=E2=80=99 and =E2=80=98qttools-5=E2=80=99 shold be in =E2=80=98inputs=E2=80=99 rather= than =E2=80=98native-inputs=E2=80=99. > + (propagated-inputs (list nx-libs > + openssh)) Don=E2=80=99t propagate OpenSSH: it should be up to the user to install it = if they want it, to avoid being too intrusive. =E2=80=98nx-libs=E2=80=99 probably doesn=E2=80=99t need to be propagated ei= ther and can be in =E2=80=98inputs=E2=80=99, no? Could you send updated patches? Thanks! Ludo=E2=80=99.