[bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".

[bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".

[Arun Isaac]

* gnu/packages/tex.scm (texlive-bin)[arguments]: Rename fix-unix-detection
phase to configure-ghostscript-executable. Replace "gs" in epstopdf.pl with
the absolute path to "gs" in the store.
---
 gnu/packages/tex.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index b6bc9dda6..91081c64b 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -176,14 +176,16 @@
                            (string-prefix? "mips64" s))))
       #:phases
        (modify-phases %standard-phases
-         (add-after 'unpack 'fix-unix-detection
+         (add-after 'unpack 'configure-ghostscript-executable
            ;; ps2eps.pl uses the "gswin32c" ghostscript executable on Windows,
            ;; and the "gs" ghostscript executable on Unix. It detects Unix by
            ;; checking for the existence of the /usr/bin directory. Since
            ;; GuixSD does not have /usr/bin, it is also detected as Windows.
-           (lambda _
+           (lambda* (#:key inputs #:allow-other-keys)
              (substitute* "utils/ps2eps/ps2eps-src/bin/ps2eps.pl"
                (("gswin32c") "gs"))
+             (substitute* "texk/texlive/linked_scripts/epstopdf/epstopdf.pl"
+               (("\"gs\"") (string-append "\"" (assoc-ref inputs "ghostscript") "/bin/gs\"")))
              #t))
          (add-after 'install 'postint
            (lambda* (#:key inputs outputs #:allow-other-keys #:rest args)
-- 
2.15.1

[bug#31850] Acknowledgement ([PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".)

[Arun Isaac]

I seem to have made one of the lines way too long. I'll fix that before
pushing, once someone has reviewed this patch. Also, should this patch
go to core-updates considering that the texlive package is very tedious
to build?

[bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".

[Ludovic Courtès]

Hello,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> * gnu/packages/tex.scm (texlive-bin)[arguments]: Rename fix-unix-detection
> phase to configure-ghostscript-executable. Replace "gs" in epstopdf.pl with
> the absolute path to "gs" in the store.

LGTM.

> I seem to have made one of the lines way too long. I'll fix that before
> pushing, once someone has reviewed this patch. Also, should this patch
> go to core-updates considering that the texlive package is very tedious
> to build?

‘texlive-bin’ has just 252 dependent it seems, many of which are
‘texlive-’ packages, which are usually quickly built.  So I’d say it’s
OK for master, but I could be missing some other way in which
‘texlive-bin’ is depended on.  Ricardo, WDYT?

Ludo’.

[bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Arun Isaac <arunisaac@systemreboot.net> skribis:
>
>> * gnu/packages/tex.scm (texlive-bin)[arguments]: Rename fix-unix-detection
>> phase to configure-ghostscript-executable. Replace "gs" in epstopdf.pl with
>> the absolute path to "gs" in the store.
>
> LGTM.
>
>> I seem to have made one of the lines way too long. I'll fix that before
>> pushing, once someone has reviewed this patch. Also, should this patch
>> go to core-updates considering that the texlive package is very tedious
>> to build?
>
> ‘texlive-bin’ has just 252 dependent it seems, many of which are
> ‘texlive-’ packages, which are usually quickly built.  So I’d say it’s
> OK for master, but I could be missing some other way in which
> ‘texlive-bin’ is depended on.  Ricardo, WDYT?

Yes, this should be fine.

Thanks!

-- 
Ricardo

[bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".

[Arun Isaac]

>> ‘texlive-bin’ has just 252 dependent it seems, many of which are
>> ‘texlive-’ packages, which are usually quickly built.  So I’d say it’s
>> OK for master, but I could be missing some other way in which
>> ‘texlive-bin’ is depended on.

But, we'd be forcing people to download the huge (~ 2.2 GB)
texlive-texmf source tarball. And, the texlive package which depends on
texlive-bin spends a good deal of time in the install phase. Is this
fine?

[bug#31850] [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".

[Ricardo Wurmus]

Arun Isaac <arunisaac@systemreboot.net> writes:

>>> ‘texlive-bin’ has just 252 dependent it seems, many of which are
>>> ‘texlive-’ packages, which are usually quickly built.  So I’d say it’s
>>> OK for master, but I could be missing some other way in which
>>> ‘texlive-bin’ is depended on.
>
> But, we'd be forcing people to download the huge (~ 2.2 GB)
> texlive-texmf source tarball. And, the texlive package which depends on
> texlive-bin spends a good deal of time in the install phase. Is this
> fine?

Only until this is built, which in the case of texlive should not take a
very long time on the build farm.

--
Ricardo

bug#31850: [PATCH] gnu: texlive-bin: Use absolute path to ghostscript executable "gs".

[Arun Isaac]

>> But, we'd be forcing people to download the huge (~ 2.2 GB)
>> texlive-texmf source tarball. And, the texlive package which depends on
>> texlive-bin spends a good deal of time in the install phase. Is this
>> fine?
>
> Only until this is built, which in the case of texlive should not take a
> very long time on the build farm.

Ok, done. Pushed!