unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#35977] [PATCH 45/47] gnu: Add python-strict-rfc3339.
@ 2019-05-29  0:36 h.nasajpour
  2019-12-10  6:47 ` Brett Gilio
  0 siblings, 1 reply; 3+ messages in thread
From: h.nasajpour @ 2019-05-29  0:36 UTC (permalink / raw)
  To: 35977; +Cc: h.nasajpour

* gnu/packages/time.scm (python-strict-rfc3339): New variable
---
 gnu/packages/time.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/time.scm b/gnu/packages/time.scm
index 1363843b31..9e23ffae14 100644
--- a/gnu/packages/time.scm
+++ b/gnu/packages/time.scm
@@ -440,3 +440,21 @@ datetime type.")
 modifies the @code{time}, @code{gettimeofday} and @code{clock_gettime} system
 calls.")
     (license gpl2)))
+
+(define-public python-strict-rfc3339
+  (package
+    (name "python-strict-rfc3339")
+    (version "0.7")
+    (source (origin
+      (method url-fetch)
+      (uri (pypi-uri "strict-rfc3339" version))
+      (sha256 (base32 "0xqjbsn0g1h88rayh5yrpdagq60zfwrfs3yvk6rmgby3vyz1gbaw"))))
+    (build-system python-build-system)
+    (arguments
+      `(
+        #:tests? #f
+        ))
+    (home-page "https://github.com/danielrichman/strict-rfc3339")
+    (synopsis "Strict, simple, lightweight RFC3339 functions.")
+    (description "Convert unix timestamps to and from RFC3339.")
+    (license license:gpl3+)))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#35977] [PATCH 45/47] gnu: Add python-strict-rfc3339.
  2019-05-29  0:36 [bug#35977] [PATCH 45/47] gnu: Add python-strict-rfc3339 h.nasajpour
@ 2019-12-10  6:47 ` Brett Gilio
  2023-06-20 21:22   ` bug#35977: " Jelle Licht
  0 siblings, 1 reply; 3+ messages in thread
From: Brett Gilio @ 2019-12-10  6:47 UTC (permalink / raw)
  To: h.nasajpour; +Cc: 35977

"h.nasajpour" <h.nasajpour@pantherx.org> writes:

> * gnu/packages/time.scm (python-strict-rfc3339): New variable
> ---
>  gnu/packages/time.scm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/gnu/packages/time.scm b/gnu/packages/time.scm
> index 1363843b31..9e23ffae14 100644
> --- a/gnu/packages/time.scm
> +++ b/gnu/packages/time.scm
> @@ -440,3 +440,21 @@ datetime type.")
>  modifies the @code{time}, @code{gettimeofday} and @code{clock_gettime} system
>  calls.")
>      (license gpl2)))
> +
> +(define-public python-strict-rfc3339
> +  (package
> +    (name "python-strict-rfc3339")
> +    (version "0.7")
> +    (source (origin
> +      (method url-fetch)
> +      (uri (pypi-uri "strict-rfc3339" version))
> +      (sha256 (base32 "0xqjbsn0g1h88rayh5yrpdagq60zfwrfs3yvk6rmgby3vyz1gbaw"))))
> +    (build-system python-build-system)
> +    (arguments
> +      `(
> +        #:tests? #f
> +        ))
> +    (home-page "https://github.com/danielrichman/strict-rfc3339")
> +    (synopsis "Strict, simple, lightweight RFC3339 functions.")
> +    (description "Convert unix timestamps to and from RFC3339.")
> +    (license license:gpl3+)))

Hi,

Again, we are needing some revisions before this package is ready to be
merged. Spare my brevity, but here is a list.

1. The commit message does not follow our style guide.
2. The indentation for the hash is incorrect. See surrounding packages
for an idea of how to do this.
3. Parens should not go on lines by themselves.
4. Disabled tests should either be disabled with reason, but only if
they fail for reasons we can not control.
5. Synopsis/Description does not follow our style guide.

As before, if you need help please do let me know :).

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#35977: [PATCH 45/47] gnu: Add python-strict-rfc3339.
  2019-12-10  6:47 ` Brett Gilio
@ 2023-06-20 21:22   ` Jelle Licht
  0 siblings, 0 replies; 3+ messages in thread
From: Jelle Licht @ 2023-06-20 21:22 UTC (permalink / raw)
  To: 35977-done; +Cc: h.nasajpour, Brett Gilio


This package can be found in guix master. Closing.
- Jelle




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-20 21:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29  0:36 [bug#35977] [PATCH 45/47] gnu: Add python-strict-rfc3339 h.nasajpour
2019-12-10  6:47 ` Brett Gilio
2023-06-20 21:22   ` bug#35977: " Jelle Licht

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).