From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:44186)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ieZJU-0006vA-3p
 for guix-patches@gnu.org; Tue, 10 Dec 2019 01:48:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ieZJS-00087M-FB
 for guix-patches@gnu.org; Tue, 10 Dec 2019 01:48:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:48871)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ieZJS-000877-3e
 for guix-patches@gnu.org; Tue, 10 Dec 2019 01:48:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ieZJS-00048U-20
 for guix-patches@gnu.org; Tue, 10 Dec 2019 01:48:02 -0500
Subject: [bug#35977] [PATCH 45/47] gnu: Add python-strict-rfc3339.
Resent-Message-ID: <handler.35977.B35977.157596047815877@debbugs.gnu.org>
From: Brett Gilio <brettg@posteo.net>
References: <h.nasajpour@pantherx.org>
 <20190529003621.3314-1-h.nasajpour@pantherx.org>
Date: Tue, 10 Dec 2019 00:47:47 -0600
In-Reply-To: <20190529003621.3314-1-h.nasajpour@pantherx.org> (h. nasajpour's
 message of "Wed, 29 May 2019 05:06:21 +0430")
Message-ID: <87lfrkk770.fsf@posteo.net>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "h.nasajpour" <h.nasajpour@pantherx.org>
Cc: 35977@debbugs.gnu.org

"h.nasajpour" <h.nasajpour@pantherx.org> writes:

> * gnu/packages/time.scm (python-strict-rfc3339): New variable
> ---
>  gnu/packages/time.scm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/gnu/packages/time.scm b/gnu/packages/time.scm
> index 1363843b31..9e23ffae14 100644
> --- a/gnu/packages/time.scm
> +++ b/gnu/packages/time.scm
> @@ -440,3 +440,21 @@ datetime type.")
>  modifies the @code{time}, @code{gettimeofday} and @code{clock_gettime} system
>  calls.")
>      (license gpl2)))
> +
> +(define-public python-strict-rfc3339
> +  (package
> +    (name "python-strict-rfc3339")
> +    (version "0.7")
> +    (source (origin
> +      (method url-fetch)
> +      (uri (pypi-uri "strict-rfc3339" version))
> +      (sha256 (base32 "0xqjbsn0g1h88rayh5yrpdagq60zfwrfs3yvk6rmgby3vyz1gbaw"))))
> +    (build-system python-build-system)
> +    (arguments
> +      `(
> +        #:tests? #f
> +        ))
> +    (home-page "https://github.com/danielrichman/strict-rfc3339")
> +    (synopsis "Strict, simple, lightweight RFC3339 functions.")
> +    (description "Convert unix timestamps to and from RFC3339.")
> +    (license license:gpl3+)))

Hi,

Again, we are needing some revisions before this package is ready to be
merged. Spare my brevity, but here is a list.

1. The commit message does not follow our style guide.
2. The indentation for the hash is incorrect. See surrounding packages
for an idea of how to do this.
3. Parens should not go on lines by themselves.
4. Disabled tests should either be disabled with reason, but only if
they fail for reasons we can not control.
5. Synopsis/Description does not follow our style guide.

As before, if you need help please do let me know :).

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/