From: Marius Bakke <mbakke@fastmail.com>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 40083-done@debbugs.gnu.org, "Ludovic Courtès" <ludo@gnu.org>
Subject: bug#40083: [PATCH] gnu: Add blktrace.
Date: Fri, 20 Mar 2020 18:35:50 +0100 [thread overview]
Message-ID: <87lfnv7wuh.fsf@devup.no> (raw)
In-Reply-To: <CAEwRq=qg9ZzBDAgVLJ64115_eS99eKiosnt622QHcQKM9hFoDA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
Vincent Legoll <vincent.legoll@gmail.com> writes:
> Is that better ?
LGTM.
> I intend to submit the rmtree patch (along a bunch of other cleanups)
> to upstream, will update guix packaging when that will happen...
Great!
[...]
> +(define-public blktrace
> + (let ((commit "f4f8ef7cdea138cfaa2f3ca0ee31fa23d3bcf1cc")
> + (revision "0"))
I added a comment about why we take this commit instead of the latest
tagged version.
[...]
> + (add-after 'unpack 'fix-gnuplot-path
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let ((gnuplot (assoc-ref inputs "gnuplot")))
> + (substitute* "btt/bno_plot.py"
> + (("gnuplot %s")
> + (string-append gnuplot "/bin/gnuplot %s")))))))))
...and ended this phase on a #t.
Applied!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-03-20 17:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 20:52 [bug#40083] [PATCH] gnu: Add blktrace Vincent Legoll
2020-03-15 21:00 ` Vincent Legoll
2020-03-15 21:47 ` Vincent Legoll
2020-03-19 14:04 ` Ludovic Courtès
2020-03-19 15:05 ` Vincent Legoll
2020-03-19 15:48 ` Marius Bakke
2020-03-19 16:01 ` Vincent Legoll
2020-03-19 17:25 ` Vincent Legoll
2020-03-20 17:35 ` Marius Bakke [this message]
2020-03-20 21:52 ` [bug#40083] cleanups submitted upstream Vincent Legoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfnv7wuh.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=40083-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=vincent.legoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).