From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:33783)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFLYx-00016P-5l
 for guix-patches@gnu.org; Fri, 20 Mar 2020 13:36:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFLYw-0006hP-5i
 for guix-patches@gnu.org; Fri, 20 Mar 2020 13:36:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39531)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jFLYw-0006hL-2n
 for guix-patches@gnu.org; Fri, 20 Mar 2020 13:36:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFLYw-00029R-0l
 for guix-patches@gnu.org; Fri, 20 Mar 2020 13:36:02 -0400
Subject: bug#40083: [PATCH] gnu: Add blktrace.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.40083.D40083.15847257608254.done@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <CAEwRq=qg9ZzBDAgVLJ64115_eS99eKiosnt622QHcQKM9hFoDA@mail.gmail.com>
References: <CAEwRq=rSZJ_hkDXNmQvuxZZmrtsStkm3hgcHD=zjHFkpTYk=jQ@mail.gmail.com>
 <CAEwRq=r09C4W_SXWGfEWwJpciz-tsZNB0M8gAB9SOawvqM_OVg@mail.gmail.com>
 <87a74c5tkk.fsf@gnu.org>
 <CAEwRq=qkjehnTvDyqLw=UPiv6gCPBW2Gh15-zqxn2L9sGYK3-Q@mail.gmail.com>
 <87y2rw9whm.fsf@devup.no>
 <CAEwRq=qodCfH7busdV1Vg4W03X+5NtHv7o_ocWcVW8y42uUBuw@mail.gmail.com>
 <CAEwRq=qg9ZzBDAgVLJ64115_eS99eKiosnt622QHcQKM9hFoDA@mail.gmail.com>
Date: Fri, 20 Mar 2020 18:35:50 +0100
Message-ID: <87lfnv7wuh.fsf@devup.no>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 40083-done@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Vincent Legoll <vincent.legoll@gmail.com> writes:

> Is that better ?

LGTM.

> I intend to submit the rmtree patch (along a bunch of other cleanups)
> to upstream, will update guix packaging when that will happen...

Great!

[...]
=20=20
> +(define-public blktrace
> +  (let ((commit "f4f8ef7cdea138cfaa2f3ca0ee31fa23d3bcf1cc")
> +        (revision "0"))

I added a comment about why we take this commit instead of the latest
tagged version.

[...]

> +           (add-after 'unpack 'fix-gnuplot-path
> +             (lambda* (#:key inputs #:allow-other-keys)
> +               (let ((gnuplot (assoc-ref inputs "gnuplot")))
> +                 (substitute* "btt/bno_plot.py"
> +                   (("gnuplot %s")
> +                    (string-append gnuplot "/bin/gnuplot %s")))))))))

...and ended this phase on a #t.

Applied!

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl50/vYACgkQoqBt8qM6
VPrzOAf/exTVOZ05aqMurI1UzuC11/Gqz1E1eiqAiSMwfiMdEqIq6vbhcdoI2cQr
LoEIWhMdX9x4tGPUVW1cIttBFWuT7ImH8zrc3Mv5ToVJQicETctZHMOQZBlq4kvK
5iMXzM3zAyVRI9gTSS3jeW5cX0LMNXrEAamZeLUqzOHSTmbNxVsnJbRwTNRZv+YR
9Tv2UW8xQ0qnfRiGKwrUMVmC8d6Xr8OyjYlRYTAr3oYHgORK4Y5rdbq3hnAu8nRp
r2Q4EShbiYp6qqrI9e+KiISkkQY+Nro291YnaPue9lRaBW8jD8Kk84LmqgeB1PQn
4av2rja3tWT7+8SHk8WHyYvdoHvGnw==
=7VKc
-----END PGP SIGNATURE-----
--=-=-=--