From: "Ludovic Courtès" <ludo@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 40083@debbugs.gnu.org
Subject: [bug#40083] [PATCH] gnu: Add blktrace.
Date: Thu, 19 Mar 2020 15:04:59 +0100 [thread overview]
Message-ID: <87a74c5tkk.fsf@gnu.org> (raw)
In-Reply-To: <CAEwRq=r09C4W_SXWGfEWwJpciz-tsZNB0M8gAB9SOawvqM_OVg@mail.gmail.com> (Vincent Legoll's message of "Sun, 15 Mar 2020 22:47:06 +0100")
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
Hi!
Vincent Legoll <vincent.legoll@gmail.com> skribis:
> Dunno what to do about the packaged .py scripts, Should I patch the
> shebang ? ("#! /usr/bin/env python") after adding python to inputs ?
Just do something like this:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 661 bytes --]
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index d19c20d056..0822748968 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4036,7 +4036,8 @@ applications.")
#:phases
(modify-phases %standard-phases (delete 'configure)))) ; no configure script
(inputs
- `(("libaio" ,libaio)))
+ `(("libaio" ,libaio)
+ ("python" ,python-wrapper))) ;for 'bno_plot.py'
(synopsis "Block layer IO tracing mechanism")
(description "Blktrace is a block layer IO tracing mechanism which provides
detailed information about request queue operations to user space. It extracts
[-- Attachment #3: Type: text/plain, Size: 262 bytes --]
and the .py files will be automatically patched.
However, ‘bno_plot.py’ refers to /bin/rm and gnuplot, and these
references should probably be replaced with absolute file names.
Could you take a look and send an updated patch?
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-03-19 14:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 20:52 [bug#40083] [PATCH] gnu: Add blktrace Vincent Legoll
2020-03-15 21:00 ` Vincent Legoll
2020-03-15 21:47 ` Vincent Legoll
2020-03-19 14:04 ` Ludovic Courtès [this message]
2020-03-19 15:05 ` Vincent Legoll
2020-03-19 15:48 ` Marius Bakke
2020-03-19 16:01 ` Vincent Legoll
2020-03-19 17:25 ` Vincent Legoll
2020-03-20 17:35 ` bug#40083: " Marius Bakke
2020-03-20 21:52 ` [bug#40083] cleanups submitted upstream Vincent Legoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a74c5tkk.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=40083@debbugs.gnu.org \
--cc=vincent.legoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).