From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: conses <contact@conses.eu>
Cc: 61082@debbugs.gnu.org
Subject: [bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143.
Date: Fri, 27 Jan 2023 09:52:20 +0100 [thread overview]
Message-ID: <87lelol5q3.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <86h6wd6ro2.fsf@conses.eu> (conses's message of "Thu, 26 Jan 2023 20:07:25 +0100")
Hello,
conses <contact@conses.eu> writes:
> * gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to
> 34a61143.
Thank you.
The commit message is incomplete: you modified pointer to upstream,
you need to write it here.
> ---
> gnu/packages/emacs-xyz.scm | 35 ++++++++++++-----------------------
> 1 file changed, 12 insertions(+), 23 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index dc378581f5..7b5888a1d1 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -21447,34 +21447,23 @@ (define-public emacs-md4rd
> (license license:gpl3+)))
>
> (define-public emacs-pulseaudio-control
> - (let ((commit "a931533140547510decdc368f39b2d2b97ca725f")
> - (revision "4"))
> + (let ((commit "34a6114357dbbc6b6720aa013e0f8a48f3739403")
> + (revision "5"))
> (package
> (name "emacs-pulseaudio-control")
> (version (git-version "0.0.1" revision commit))
Base version seems to be "0.1", according to puleseaudio-control.el. In
this case, you can restart revision to "1" (or "0").
> - (source
> - (origin
> - (method git-fetch)
> - (uri (git-reference
> - (url "https://github.com/flexibeast/pulseaudio-control")
> - (commit commit)))
> - (file-name (git-file-name name version))
> - (sha256
> - (base32
> - "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76"))))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.sr.ht/~flexibeast/pulseaudio-control")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5"))))
> (build-system emacs-build-system)
> - (arguments
> - '(#:phases (modify-phases %standard-phases
> - (add-after 'unpack 'patch-file-name
> - (lambda* (#:key inputs #:allow-other-keys)
> - (let ((pulseaudio (assoc-ref inputs "pulseaudio")))
> - (chmod "pulseaudio-control.el" #o600)
> - (emacs-substitute-variables "pulseaudio-control.el"
> - ("pulseaudio-control-pactl-path"
> - (string-append pulseaudio "/bin/pactl")))
> - #t))))))
Why did you remove this phase? AFAICT, pulseaudio-control-pactl-path
still exists.
> (inputs (list pulseaudio))
> - (home-page "https://github.com/flexibeast/pulseaudio-control")
> + (home-page "https://git.sr.ht/~flexibeast/pulseaudio-control")
This also need to be specified in the commit message.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-01-27 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 19:07 [bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143 conses
2023-01-27 8:52 ` Nicolas Goaziou [this message]
2023-01-28 12:59 ` conses
2023-01-28 16:30 ` Nicolas Goaziou
2023-01-28 12:51 ` [bug#61082] [PATCH v2] " conses
2023-01-28 19:05 ` [bug#61082] [PATCH v3] " conses
2023-01-29 14:45 ` bug#61082: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lelol5q3.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=61082@debbugs.gnu.org \
--cc=contact@conses.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).