From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: conses <contact@conses.eu>
Cc: 61082@debbugs.gnu.org
Subject: [bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143.
Date: Sat, 28 Jan 2023 17:30:06 +0100 [thread overview]
Message-ID: <874jsak4fl.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <86h6wa6chn.fsf_-_@conses.eu> (conses's message of "Sat, 28 Jan 2023 13:59:48 +0100")
Hello,
conses <contact@conses.eu> writes:
> Because this might have been needed when the package didn't allow
> the pactl executable path to be found dynamically, but as per
> https://github.com/flexibeast/pulseaudio-control/commit/c8640fceb530ab7a1aa551d70f7ee222147d95cf
> this is no longer needed.
I don't think
(or (executable-find "pactl") "/usr/bin/pactl")
is equivalent to
(search-input-file inputs "/bin/pactl")
Some Emacs packages remove those `executable-find' calls, e.g.,
emacs-nov-el, emacs-emacsql-sqlite3, emacs-telega, etc.
It does make sense to keep this phase (but you can remove the initial
chmod call and the final #T), unless I'm missing something. We want the
Emacs package to always refer to its own Pulseaudio input, don't we?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-01-28 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 19:07 [bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143 conses
2023-01-27 8:52 ` Nicolas Goaziou
2023-01-28 12:59 ` conses
2023-01-28 16:30 ` Nicolas Goaziou [this message]
2023-01-28 12:51 ` [bug#61082] [PATCH v2] " conses
2023-01-28 19:05 ` [bug#61082] [PATCH v3] " conses
2023-01-29 14:45 ` bug#61082: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jsak4fl.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=61082@debbugs.gnu.org \
--cc=contact@conses.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).