From: conses <contact@conses.eu>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 61082@debbugs.gnu.org
Subject: [bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143.
Date: Sat, 28 Jan 2023 13:59:48 +0100 [thread overview]
Message-ID: <86h6wa6chn.fsf_-_@conses.eu> (raw)
In-Reply-To: <87lelol5q3.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Fri, 27 Jan 2023 09:52:20 +0100")
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
Hi Nicolas,
>> - (source
>> - (origin
>> - (method git-fetch)
>> - (uri (git-reference
>> - (url "https://github.com/flexibeast/pulseaudio-control")
>> - (commit commit)))
>> - (file-name (git-file-name name version))
>> - (sha256
>> - (base32
>> - "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76"))))
>> + (source (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://git.sr.ht/~flexibeast/pulseaudio-control")
>> + (commit commit)))
>> + (file-name (git-file-name name version))
>> + (sha256
>> + (base32
>> + "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5"))))
>> (build-system emacs-build-system)
>> - (arguments
>> - '(#:phases (modify-phases %standard-phases
>> - (add-after 'unpack 'patch-file-name
>> - (lambda* (#:key inputs #:allow-other-keys)
>> - (let ((pulseaudio (assoc-ref inputs "pulseaudio")))
>> - (chmod "pulseaudio-control.el" #o600)
>> - (emacs-substitute-variables "pulseaudio-control.el"
>> - ("pulseaudio-control-pactl-path"
>> - (string-append pulseaudio "/bin/pactl")))
>> - #t))))))
>
> Why did you remove this phase? AFAICT, pulseaudio-control-pactl-path
> still exists.
>
>
Because this might have been needed when the package didn't allow
the pactl executable path to be found dynamically, but as per
https://github.com/flexibeast/pulseaudio-control/commit/c8640fceb530ab7a1aa551d70f7ee222147d95cf
this is no longer needed.
--
Best regards,
conses
next prev parent reply other threads:[~2023-01-28 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 19:07 [bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143 conses
2023-01-27 8:52 ` Nicolas Goaziou
2023-01-28 12:59 ` conses [this message]
2023-01-28 16:30 ` Nicolas Goaziou
2023-01-28 12:51 ` [bug#61082] [PATCH v2] " conses
2023-01-28 19:05 ` [bug#61082] [PATCH v3] " conses
2023-01-29 14:45 ` bug#61082: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h6wa6chn.fsf_-_@conses.eu \
--to=contact@conses.eu \
--cc=61082@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).