From: Jan Nieuwenhuizen <janneke@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 41541@debbugs.gnu.org, Mathieu Othacehe <othacehe@gnu.org>
Subject: [bug#41541] [PATCH 3/8] system: Add 'multiboot-modules' field to <boot-parameters>.
Date: Sun, 07 Jun 2020 09:39:31 +0200 [thread overview]
Message-ID: <87k10js4ss.fsf@gnu.org> (raw)
In-Reply-To: <878sh0wjj3.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 06 Jun 2020 12:55:28 +0200")
Ludovic Courtès writes:
Hi,
> Mathieu Othacehe <othacehe@gnu.org> skribis:
>
>>> + (mach (if (%current-target-system)
>>> + ;; A cross-built GNUmach does not work
>>> + (with-parameters ((%current-system "i686-linux")
>>> + (%current-target-system #f))
>>> + mach)
>>
>> Maybe it would make more sense to check if we are on a Hurd system,
>> rather than just checking for %current-target-system to be set, don't
>> know.
>
> If this hack is still needed, can we move it away to hurd-os.tmpl, or to
> the ‘gnumach’ package itself or something?
Yes, it's needed; GNUmach does not work when cross-built.
> I think it’s best to keep (gnu system) free of any such assumptions.
Ok.
Changed this to
--8<---------------cut here---------------start------------->8---
(define (operating-system-kernel-file os)
"Return an object representing the absolute file name of the kernel image of
OS."
(if (operating-system-hurd os)
(file-append (operating-system-kernel os) "/boot/gnumach")
(file-append (operating-system-kernel os)
"/" (system-linux-image-file-name))))
--8<---------------cut here---------------end--------------->8---
and compensated for MACH (folded in a later patch) in
gnu/system/hurd.scm, like
--8<---------------cut here---------------start------------->8---
(define %hurd-default-operating-system-kernel
(if (hurd-system?)
gnumach
;; A cross-built GNUmach does not work
(with-parameters ((%current-system "i686-linux")
(%current-target-system #f))
gnumach)))
[...]
(define %hurd-default-operating-system
(operating-system
(kernel %hurd-default-operating-system-kernel)
[...]
--8<---------------cut here---------------end--------------->8---
>>> + (libc (if target
>>> + (with-parameters ((%current-target-system #f))
>>> + (cross-libc target))
>>> + glibc))
>>
>> In the future, it would be nice to make this think transparent. Anyway,
>> for now this is the best we can do I think.
>
> Yeah, perhaps add a FIXME.
Yes, did that!
>>> "--x-xattr-translator-records"
>
> Do we need this yet? If it can wait for later, that’s even nicer IMO as
> it would allow us to separate concerns.
Not "just" yet, it's used after the introduction of hurd-boot.scm, where
I use setxattr instead of MAKEDEV. Moved it up the stack, to
8dff3d0382 hurd-boot: Use setxattr instead of MAKEDEV.
Phew. I think that was it for this round. I've reset wip-hurd-vm so
that we can have another good look tomorrow.
Thanks a lot!
Janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
next prev parent reply other threads:[~2020-06-07 7:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200604135914.4499-1-janneke@gnu.org>
[not found] ` <20200604135914.4499-2-janneke@gnu.org>
2020-06-06 10:45 ` [bug#41541] [PATCH 1/8] system: Add 'hurd' field to <operating-system> Ludovic Courtès
2020-06-06 11:14 ` Jan Nieuwenhuizen
[not found] ` <20200604135914.4499-3-janneke@gnu.org>
2020-06-06 10:48 ` [bug#41541] [PATCH 2/8] bootloader: Extend `<menu-entry>' for multiboot Ludovic Courtès
2020-06-06 12:00 ` Jan Nieuwenhuizen
[not found] ` <20200604135914.4499-4-janneke@gnu.org>
[not found] ` <87eeqsmyxy.fsf@gnu.org>
2020-06-06 10:55 ` [bug#41541] [PATCH 3/8] system: Add 'multiboot-modules' field to <boot-parameters> Ludovic Courtès
2020-06-07 7:39 ` Jan Nieuwenhuizen [this message]
[not found] ` <20200604135914.4499-5-janneke@gnu.org>
2020-06-06 10:57 ` [bug#41541] [PATCH 4/8] bootloader: grub: Add support for multiboot Ludovic Courtès
2020-06-06 12:08 ` Jan Nieuwenhuizen
[not found] ` <20200604135914.4499-6-janneke@gnu.org>
2020-06-06 10:57 ` [bug#41541] [PATCH 5/8] system: Use 'hurd' package in label Ludovic Courtès
[not found] ` <20200604135914.4499-7-janneke@gnu.org>
[not found] ` <875zc4mxtu.fsf@gnu.org>
2020-06-06 10:58 ` [bug#41541] [PATCH 6/8] system: examples: Add bare-hurd.tmpl Jan Nieuwenhuizen
2020-06-06 16:49 ` Mathieu Othacehe
2020-06-06 22:44 ` Jan Nieuwenhuizen
2020-06-06 10:59 ` Ludovic Courtès
2020-06-06 12:34 ` Jan Nieuwenhuizen
[not found] ` <20200604135914.4499-9-janneke@gnu.org>
2020-06-06 11:05 ` [bug#41541] [PATCH 8/8] system: Add `hurd-activation' Ludovic Courtès
2020-06-06 14:21 ` Jan Nieuwenhuizen
[not found] ` <20200604135914.4499-8-janneke@gnu.org>
2020-06-06 11:08 ` [bug#41541] [PATCH 7/8] services: hurd: Add `hurd-etc-service' Ludovic Courtès
2020-06-06 14:31 ` Jan Nieuwenhuizen
2020-06-07 20:02 ` Ludovic Courtès
2020-06-07 20:31 ` Jan Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k10js4ss.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=41541@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).