From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cLieONiZ3F4DcgAA0tVLHw (envelope-from ) for ; Sun, 07 Jun 2020 07:40:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QIhsNNiZ3F6zDAAAB5/wlQ (envelope-from ) for ; Sun, 07 Jun 2020 07:40:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7273A940704 for ; Sun, 7 Jun 2020 07:40:08 +0000 (UTC) Received: from localhost ([::1]:51166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhpuZ-0000CK-FF for larch@yhetil.org; Sun, 07 Jun 2020 03:40:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhpuU-0000CE-K8 for guix-patches@gnu.org; Sun, 07 Jun 2020 03:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhpuU-0003CY-B1 for guix-patches@gnu.org; Sun, 07 Jun 2020 03:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhpuU-0001dw-8J for guix-patches@gnu.org; Sun, 07 Jun 2020 03:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41541] [PATCH 3/8] system: Add 'multiboot-modules' field to . Resent-From: Jan Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 07 Jun 2020 07:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41541 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 41541@debbugs.gnu.org, Mathieu Othacehe Received: via spool by 41541-submit@debbugs.gnu.org id=B41541.15915155826283 (code B ref 41541); Sun, 07 Jun 2020 07:40:02 +0000 Received: (at 41541) by debbugs.gnu.org; 7 Jun 2020 07:39:42 +0000 Received: from localhost ([127.0.0.1]:53271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhpu9-0001dH-MB for submit@debbugs.gnu.org; Sun, 07 Jun 2020 03:39:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhpu8-0001d4-74 for 41541@debbugs.gnu.org; Sun, 07 Jun 2020 03:39:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48701) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhpu2-0003Aa-Tq; Sun, 07 Jun 2020 03:39:34 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=39130 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jhpu2-0002Eo-38; Sun, 07 Jun 2020 03:39:34 -0400 From: Jan Nieuwenhuizen Organization: AvatarAcademy.nl References: <20200604135914.4499-1-janneke@gnu.org> <20200604135914.4499-4-janneke@gnu.org> <87eeqsmyxy.fsf@gnu.org> <878sh0wjj3.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Sun, 07 Jun 2020 09:39:31 +0200 In-Reply-To: <878sh0wjj3.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 06 Jun 2020 12:55:28 +0200") Message-ID: <87k10js4ss.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: wtSFCMyp0LSI Ludovic Court=C3=A8s writes: Hi, > Mathieu Othacehe skribis: > >>> + (mach (if (%current-target-system) >>> + ;; A cross-built GNUmach does not work >>> + (with-parameters ((%current-system "i686-linux") >>> + (%current-target-system #f)) >>> + mach) >> >> Maybe it would make more sense to check if we are on a Hurd system, >> rather than just checking for %current-target-system to be set, don't >> know. > > If this hack is still needed, can we move it away to hurd-os.tmpl, or to > the =E2=80=98gnumach=E2=80=99 package itself or something? Yes, it's needed; GNUmach does not work when cross-built. > I think it=E2=80=99s best to keep (gnu system) free of any such assumptio= ns. Ok. Changed this to --8<---------------cut here---------------start------------->8--- (define (operating-system-kernel-file os) "Return an object representing the absolute file name of the kernel image= of OS." (if (operating-system-hurd os) (file-append (operating-system-kernel os) "/boot/gnumach") (file-append (operating-system-kernel os) "/" (system-linux-image-file-name)))) --8<---------------cut here---------------end--------------->8--- and compensated for MACH (folded in a later patch) in gnu/system/hurd.scm, like --8<---------------cut here---------------start------------->8--- (define %hurd-default-operating-system-kernel (if (hurd-system?) gnumach ;; A cross-built GNUmach does not work (with-parameters ((%current-system "i686-linux") (%current-target-system #f)) gnumach))) [...] (define %hurd-default-operating-system (operating-system (kernel %hurd-default-operating-system-kernel) [...] --8<---------------cut here---------------end--------------->8--- >>> + (libc (if target >>> + (with-parameters ((%current-target-system #f)) >>> + (cross-libc target)) >>> + glibc)) >> >> In the future, it would be nice to make this think transparent. Anyway, >> for now this is the best we can do I think. > > Yeah, perhaps add a FIXME. Yes, did that! >>> "--x-xattr-translator-records" > > Do we need this yet? If it can wait for later, that=E2=80=99s even nicer= IMO as > it would allow us to separate concerns. Not "just" yet, it's used after the introduction of hurd-boot.scm, where I use setxattr instead of MAKEDEV. Moved it up the stack, to 8dff3d0382 hurd-boot: Use setxattr instead of MAKEDEV. Phew. I think that was it for this round. I've reset wip-hurd-vm so that we can have another good look tomorrow. Thanks a lot! Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com