From: Jan Nieuwenhuizen <janneke@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 41541@debbugs.gnu.org
Subject: [bug#41541] [PATCH 7/8] services: hurd: Add `hurd-etc-service'.
Date: Sun, 07 Jun 2020 22:31:14 +0200 [thread overview]
Message-ID: <874krmd3e5.fsf@gnu.org> (raw)
In-Reply-To: <871rmqskzm.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 07 Jun 2020 22:02:05 +0200")
Ludovic Courtès writes:
Hi,
> Jan Nieuwenhuizen <janneke@gnu.org> skribis:
>
>> From 4cef6e73ce9fd137640c1c00f98958cdc41dda90 Mon Sep 17 00:00:00 2001
>> From: "Jan (janneke) Nieuwenhuizen" <janneke@gnu.org>
>> Date: Sat, 25 Apr 2020 11:55:56 +0200
>> Subject: [PATCH] services: Support etc-service for the Hurd.
>>
>> * gnu/system.scm (operating-system-etc-service): Cater for missing nsswitch
>> and missing sudoers-file. For the Hurd, add "login" and "motd".
>> (hurd-default-essential-services): Add operating-system-etc-service.
>
> Perfect!
>
> [...]
>
>> + ,@(if sudoers `(("sudoers" ,sudoers)) '())
>> + ,@(if hurd `(("login" ,(file-append hurd "/etc/login"))
>> + ("motd" ,(file-append hurd "/etc/motd"))))))))
>
> We’re missing the ‘else’ branch here.
Ah yes -- make check found that for me...
http://git.savannah.gnu.org/cgit/guix.git/commit/?h=wip-hurd-vm&id=c7012882da88760fdc7ae5413dc80bd768469341
; already fixed :-)
> Apart from that, LGTM!
Great...getting there!
Janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
prev parent reply other threads:[~2020-06-07 20:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200604135914.4499-1-janneke@gnu.org>
[not found] ` <20200604135914.4499-2-janneke@gnu.org>
2020-06-06 10:45 ` [bug#41541] [PATCH 1/8] system: Add 'hurd' field to <operating-system> Ludovic Courtès
2020-06-06 11:14 ` Jan Nieuwenhuizen
[not found] ` <20200604135914.4499-3-janneke@gnu.org>
2020-06-06 10:48 ` [bug#41541] [PATCH 2/8] bootloader: Extend `<menu-entry>' for multiboot Ludovic Courtès
2020-06-06 12:00 ` Jan Nieuwenhuizen
[not found] ` <20200604135914.4499-4-janneke@gnu.org>
[not found] ` <87eeqsmyxy.fsf@gnu.org>
2020-06-06 10:55 ` [bug#41541] [PATCH 3/8] system: Add 'multiboot-modules' field to <boot-parameters> Ludovic Courtès
2020-06-07 7:39 ` Jan Nieuwenhuizen
[not found] ` <20200604135914.4499-5-janneke@gnu.org>
2020-06-06 10:57 ` [bug#41541] [PATCH 4/8] bootloader: grub: Add support for multiboot Ludovic Courtès
2020-06-06 12:08 ` Jan Nieuwenhuizen
[not found] ` <20200604135914.4499-6-janneke@gnu.org>
2020-06-06 10:57 ` [bug#41541] [PATCH 5/8] system: Use 'hurd' package in label Ludovic Courtès
[not found] ` <20200604135914.4499-7-janneke@gnu.org>
[not found] ` <875zc4mxtu.fsf@gnu.org>
2020-06-06 10:58 ` [bug#41541] [PATCH 6/8] system: examples: Add bare-hurd.tmpl Jan Nieuwenhuizen
2020-06-06 16:49 ` Mathieu Othacehe
2020-06-06 22:44 ` Jan Nieuwenhuizen
2020-06-06 10:59 ` Ludovic Courtès
2020-06-06 12:34 ` Jan Nieuwenhuizen
[not found] ` <20200604135914.4499-9-janneke@gnu.org>
2020-06-06 11:05 ` [bug#41541] [PATCH 8/8] system: Add `hurd-activation' Ludovic Courtès
2020-06-06 14:21 ` Jan Nieuwenhuizen
[not found] ` <20200604135914.4499-8-janneke@gnu.org>
2020-06-06 11:08 ` [bug#41541] [PATCH 7/8] services: hurd: Add `hurd-etc-service' Ludovic Courtès
2020-06-06 14:31 ` Jan Nieuwenhuizen
2020-06-07 20:02 ` Ludovic Courtès
2020-06-07 20:31 ` Jan Nieuwenhuizen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874krmd3e5.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=41541@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).