From: Marius Bakke <marius@gnu.org>
To: Lars-Dominik Braun <ldb@leibniz-psychology.org>
Cc: 42306@debbugs.gnu.org
Subject: [bug#42306] [PATCH] gnu: Add nfs4-acl-tools
Date: Thu, 30 Jul 2020 00:01:28 +0200 [thread overview]
Message-ID: <87k0ymq8uf.fsf@gnu.org> (raw)
In-Reply-To: <20200727071139.GB3225@zpidnp36>
[-- Attachment #1.1: Type: text/plain, Size: 455 bytes --]
Lars-Dominik Braun <ldb@leibniz-psychology.org> writes:
> Hey Marius,
>
>> Sorry for the late reply...
> no problem.
>
>> The patch mostly LGTM, but no longer applies. Can you rebase it on
>> current master? Meanwhile, a few comments:
> Sure, see attached patch, which (hopefully) also improves the description.
Thanks! FYI I had to convert the patch from ISO-8859-1 encoding to
UTF-8 in order to make it apply.
Applied with the following changes:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: diff --]
[-- Type: text/x-patch, Size: 1227 bytes --]
diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scm
index 128afc52c2..a6409765ff 100644
--- a/gnu/packages/acl.scm
+++ b/gnu/packages/acl.scm
@@ -27,7 +27,6 @@
#:use-module (gnu packages attr)
#:use-module (gnu packages autotools)
#:use-module (gnu packages base)
- #:use-module (gnu packages bash)
#:use-module (gnu packages gettext)
#:use-module (gnu packages perl)
#:use-module (guix packages)
@@ -116,14 +115,13 @@
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'fix-bin-sh
- (lambda* (#:key inputs native-inputs #:allow-other-keys)
+ (lambda _
(substitute* "include/buildmacros"
- (("/bin/sh") (string-append (assoc-ref inputs "bash-minimal") "/bin/sh")))
+ (("/bin/sh") (which "sh")))
#t)))))
(native-inputs
`(("automake" ,automake)
("autoconf" ,autoconf)
- ("bash-minimal" ,bash-minimal)
("libtool" ,libtool)))
(inputs
`(("attr" ,attr)))
@@ -134,4 +132,3 @@
POSIX equivalents @command{getfacl} and @command{setfacl}. They fetch and
manipulate access control lists for files and directories on NFSv4 mounts.")
(license bsd-3)))
-
[-- Attachment #1.3: Type: text/plain, Size: 488 bytes --]
...however I also decided to move it to (gnu packages nfs).
> I noticed linting fails with a pattern matching error, because git:// protocol
> URI’s are not supported. The second patch fixes it, but I’m not sure that’s a
> “proper” solution.
Me neither and I don't feel like jumping on that one right away. :-)
It seems we already have a number of git:// URLs around so it would be
good to fix it, can you submit the second patch to a separate issue?
Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-07-29 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 9:21 [bug#42306] [PATCH] gnu: Add nfs4-acl-tools Lars-Dominik Braun
2020-07-25 15:20 ` Marius Bakke
2020-07-27 7:11 ` Lars-Dominik Braun
2020-07-29 22:01 ` Marius Bakke [this message]
2020-07-30 7:17 ` Lars-Dominik Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0ymq8uf.fsf@gnu.org \
--to=marius@gnu.org \
--cc=42306@debbugs.gnu.org \
--cc=ldb@leibniz-psychology.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).